Update zoneinfo compilation in zoneinfo crate#532
Merged
Conversation
All zoneinfo tests are passing on this commit
Remove some dead / out of date code
Manishearth
approved these changes
Sep 2, 2025
Contributor
Manishearth
left a comment
There was a problem hiding this comment.
Not looking too closely at this, but overall seems fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the internal approach to compiling zoneinfo files into transition data.
The main goal of this PR is to support slim format compiled data in
timezone_provider, which this PR should unblock as aCompiledTransitionis now compiled in slim by default. This new approach also has some added benefits: one, it appears to be more correct as it fixes previously known bugs that needed to be addressed, and two, this approach is simpler to understand and doesn't do some of the backtracking that was occurring in the old approach.