Fix validity checks#523
Merged
jedel1043 merged 1 commit intoboa-dev:mainfrom Aug 26, 2025
Merged
Conversation
Contributor
Author
|
@linusg is this PR useful for you without a release or should we make a release? |
Contributor
|
Thanks for the quick fix! I prefer to update more frequently than tagged releases for most things I depend on so a commit is all I need :) |
Contributor
Author
|
Works for me; I'm able to patch this in v8 as well. So it only depends on what boa needs |
Member
|
Boa does require a release since we're releasing a new version of |
Contributor
Author
|
That works for me. @jedel1043 can we merge this then? I'll prepare a release. |
Contributor
Author
|
@linusg and I can confirm that temporal_rs 0.0.13 + this patch causes no new test262 failures |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Aug 27, 2025
Uplifts boa-dev/temporal#523 A last minute merged PR broke some tests; this fixes them until we make another release. Change-Id: I0c57492edcf46ea35dff1675d1f3d10506fbafcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6886224 Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1506855}
mohd-akram
pushed a commit
to gsource-mirror/chromium-src-third_party-rust
that referenced
this pull request
Jan 9, 2026
Uplifts boa-dev/temporal#523 A last minute merged PR broke some tests; this fixes them until we make another release. Change-Id: I0c57492edcf46ea35dff1675d1f3d10506fbafcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6886224 Auto-Submit: Manish Goregaokar <manishearth@google.com> Commit-Queue: Manish Goregaokar <manishearth@google.com> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/main@{#1506855} NOKEYCHECK=True GitOrigin-RevId: c694faad40700708952d9d49f2739656184df4f0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec only requires dates to be checked, not times.
While I'm at it, I added some robustness.