temporal_rs depends on icu_locale_data unconditionally

[legendecas]

Both icu_calendar and icu_locale have its own compiled_data feature. This would bring in dependency on icu_calendar_data and icu_locale_data respectively.

If an embedder of temporal_rs already has its own bundled icu data, temporal_rs would still enable the compiled_data feature on icu_locale and thus enable icu_locale_data, duplicating the icu data set in the final product.

(icu_calendar with feature unstable is compiled without compiled_data)

Refs:

temporal/Cargo.toml

Lines 48 to 49 in 71eecd4

	icu_calendar = { version = "2.1.0", default-features = false, features = ["unstable"] }
	icu_locale = "2.1.0"

[Manishearth]

temporal_rs does not currently provide a way to plug in custom ICU4X data, and is built on the assumption that you are using ICU4X compiled data. It uses very little ICU4X compiled data (I think actually as of the yet unreleased ICU4X 2.2, it will not need to link any compiled data, though it will still depend on some).

Note that ICU4X compiled data is not the same as ICU4C's bundled data. Having ICU4C bundled data does not help ICU4X except in the narrow case of zoneinfo64.res, which temporal_rs supports plugging through the timezone_provider crate.

that said, temporal_rs doesn't need icu_locale_data at all. It should be depending on icu_locale_core.

[Manishearth]

Ah, unfortunately I can't get rid of the dep completely since icu_calendar depends on it too: #694

However, the code from that is not actually linked in by anything used in Temporal, since Temporal doesn't do anything with locale based data loading. So this should not be a cost for you; it is just additional code that needs to be built but will be dropped.