fix eval delete bindings#5344
Conversation
Test262 conformance changes
Fixed tests (4):Broken tests (1):Tested main commit: |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #5344 +/- ##
===========================================
+ Coverage 47.24% 59.91% +12.67%
===========================================
Files 476 590 +114
Lines 46892 63803 +16911
===========================================
+ Hits 22154 38228 +16074
- Misses 24738 25575 +837 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhuzhu81998
left a comment
There was a problem hiding this comment.
i am not familiar with this part of the codebase, but this feels, kinda hacky?
are you sure this is not something that happens because of incompliance with spec somewhere?
Yeah, fair point. the current approach is not clean enough. The Test262 report also caught a regression around eval("var x=delete(x)") so I’ll rework this instead of trying to patch around it |
Fixes #5333.
Direct eval-created local
varand function bindings were not treated as deletable at runtime, sodeleteleft them visible and latervarinitialization could recreate them.This tracks deleted eval-created local bindings in function environments and avoids recreating them after deletion.
Tests: