feat(relay): implement NIP-ER event reminder support (kind:30300)#934
Draft
wpfleger96 wants to merge 2 commits into
Draft
feat(relay): implement NIP-ER event reminder support (kind:30300)#934wpfleger96 wants to merge 2 commits into
wpfleger96 wants to merge 2 commits into
Conversation
90eda63 to
512d676
Compare
54858c7 to
aca85a7
Compare
Adds relay-side support for NIP-ER encrypted event reminders: Write path (ingest): - Register KIND_EVENT_REMINDER (30300) as parameterized replaceable, global-only, and UsersWrite-scoped - Validate not_before tag: exactly one, decimal digits only, no leading zeros, range 0..=MAX_SAFE_INTEGER - Reject expiration <= not_before when both are present and parseable Read path (REQ/COUNT/bridge): - AUTHOR_ONLY_KINDS array gates visibility — only the authenticated event author may read kind:30300 events - Exclusive author-only filters (kinds:[30300]) require authors=[self] or get CLOSED/403 - Mixed-kind filters pass the gate but per-event filtering silently omits other authors' reminders - COUNT fast path disabled when author-only kinds are in play to prevent leaking aggregate counts Integration tests (e2e_event_reminder.rs): - Write validation: valid, missing, duplicate, malformed not_before; expiration ordering; edge cases (0, MAX_SAFE_INTEGER) - Read filtering: author self-query, cross-user rejection (HTTP 403 and WS CLOSED), mixed-kind omission, replacement semantics Signed-off-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@sprout-oss.stage.blox.sqprod.co> Co-authored-by: Will Pfleger <wpfleger@squareup.com> Signed-off-by: Will Pfleger <wpfleger@squareup.com>
8432f61 to
6503871
Compare
The spec requires not_before on pending reminders only — terminal states (done/cancelled) and bookmarks omit it. The validator incorrectly required exactly one not_before on all kind:30300 events, blocking the entire completion/cancellation lifecycle. Also adds d-tag structure validation per spec: reject zero, empty, or duplicate d tags. Co-authored-by: Will Pfleger <will@pfleger.dev> Signed-off-by: Will Pfleger <will@pfleger.dev>
6503871 to
7a75e4a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Stack: this PR → #957
This is the foundation PR. #957 (push scheduler) stacks on top of this branch.
Summary
Adds relay-side support for NIP-ER encrypted event reminders (
kind:30300). This is a parameterized replaceable, author-only event type that carries a publicnot_beforeschedule tag while keeping reminder content NIP-44 encrypted.Changes
Write path (
sprout-core,sprout-relay/handlers/ingest)KIND_EVENT_REMINDER(30300) insprout-core::kindas parameterized replaceable, global-onlyAUTHOR_ONLY_KINDSarray for cross-cutting read-path enforcementnot_beforetag: at most one permitted, decimal digits only, no leading zeros (except"0"), range0..=9007199254740991(Number.MAX_SAFE_INTEGER). Optional — terminal-state and bookmark reminders omit itdtag: exactly one required, non-emptyexpiration <= not_before(window would expire before due)UsersWrite— same as contacts, read-state, engramsRead path (
sprout-relay/handlers/req,count,api/bridge)author_only_filters_authorized(): pre-filter gate rejects exclusivekind:30300filters unlessauthors=[self]— returnsCLOSED restricted:(WS) or HTTP 403is_author_only_event(): per-event filter silently omits other authors' reminders from mixed-kind result setsfilter_can_match_author_only_kinds(): forces COUNT handler onto the slow path (per-event filtering) to prevent leaking aggregate counts/query, HTTP/count, and HTTP/querysearch pathsIntegration tests (
e2e_event_reminder.rs)16 e2e tests covering:
not_before, d-tag validation, expiration ordering, edge cases (0, MAX_SAFE_INTEGER)