fix(desktop): clear clippy lints in agents/mesh_llm commands#817
Merged
Conversation
Three lints slipped past #798's merge gate and are failing the desktop-tauri-clippy pre-push hook on main with -D warnings: - agents.rs: let_and_return — return the expression directly - mesh_llm.rs (x2): needless_borrow — `state` is already &AppState, so &state was a double reference at the call sites All idiomatic fixes, no behavior change. Unbreaks main's clippy hook. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
michaelneale
added a commit
that referenced
this pull request
Jun 4, 2026
* origin/main: (36 commits) fix: use immutable commit-SHA URLs in screenshot PR comments (#842) feat(mobile+desktop): two-tier Slack-style app icon badge (#802) chore: simplify file-size check to a flat 1000-line limit (#839) fix(desktop): robust emoji picker — unify picker + fix custom emoji in editing, status, reactions (#837) feat(desktop): reusable screenshot workflow for agents (#826) desktop(mesh-llm): let a serving node route a different model (#833) chore(release): release version 0.3.9 (#832) fix: native arbitrary-file download + image context-menu flash (#830) fix(desktop): custom emoji reaction rendering + picker autofocus (#831) Mesh-LLM v1: relay-gated direct-iroh inference between users (WAN) (#822) chore(release): release version 0.3.8 (#829) chore(release): release version 0.3.7 (#825) feat: code block rendering, syntax highlighting, and compose fixes (#803) feat: custom emoji — user-owned NIP-30 sets with a client-side union (#816) Install sprout-cli skill at repo root + fix desktop clippy (#818) fix(desktop): use public re-export path for ensure_client_node_for_model (#824) refactor(desktop): feature-gate mesh-llm-sdk behind optional Cargo feature (#823) fix(desktop): align workflow read/save commands to the frontend contract (#820) fix(desktop): disable mesh-llm auto-build to prevent git config corruption (#819) fix(desktop): clear clippy lints in agents/mesh_llm commands (#817) ... # Conflicts: # Cargo.lock # desktop/scripts/check-file-sizes.mjs # desktop/src-tauri/Cargo.toml # desktop/src/app/AppShell.tsx # desktop/src/app/AppTopChrome.tsx # desktop/src/features/messages/hooks.ts # desktop/src/features/workspaces/useWorkspaceInit.ts # desktop/src/shared/api/tauri.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three clippy lints slipped past #798 (mesh-llm)'s merge gate and are currently failing the
desktop-tauri-clippypre-push hook onmain(with-D warnings):agents.rs:507—let_and_return: return the expression directlymesh_llm.rs:76/mesh_llm.rs:99—needless_borrow(x2):stateis already&AppStateat both call sites, so&statewas a double referenceWhy
mainis currently red on the desktop-tauri-clippy hook — reproducible by runningjust desktop-tauri-clippyon a clean checkout of41a3fc1. This blocks any branch's push hook. Fixing it in a small, correctly-scoped PR (these are main's files, not feature work) unbreaks the hook for everyone.Verification
All 6 pre-push gates run by hand and green:
just clippy✓just desktop-tauri-clippy✓just test-unit✓just desktop-tauri-test✓just desktop-test(425) ✓just mobile-test(341) ✓Idiomatic fixes, no behavior change.
Co-authored-by: Brain