Skip to content

Fix desktop right-side panel chrome overlap#806

Merged
wesbillman merged 13 commits into
mainfrom
right-side
Jun 2, 2026
Merged

Fix desktop right-side panel chrome overlap#806
wesbillman merged 13 commits into
mainfrom
right-side

Conversation

@thomaspblock

@thomaspblock thomaspblock commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Summary

  • Fix responsive right-side panel behavior for threads, agent activity, and user profiles so narrow layouts use a single-panel takeover below the global top chrome while preserving search and action buttons.
  • Systematize panel layering and width observation with shared z-index constants, element-width breakpoints, and 300px minimum column behavior for both channel panels and the Home inbox split view.
  • Refine Home inbox detail alignment, message row spacing, avatar sizing, sticky date divider offset, and composer width so one-column and two-column views line up consistently.
  • Polish agent activity UI by stabilizing the header, using agent/requester avatars where appropriate, improving transcript alignment, and avoiding clipped inline activity avatars.
  • Tune sheet/dialog light-theme treatment so modal dimming follows Sprout's selected theme, channel management panels stay light in light mode, and the members header drop shadow is removed.

Test plan

  • Open a channel and verify thread, agent activity, and profile panels do not overlap the top search/actions at narrow widths.
  • Resize channel panels and confirm each column keeps a 300px minimum before collapsing into single-panel view.
  • Open Home inbox, resize the list/detail split, and confirm two-column and one-column detail alignment stays consistent.
  • Scroll message timelines and inbox details to confirm sticky date dividers stay below headers and composers do not expose content underneath.
  • Open Members, Add agent, and Channel settings in light and dark themes to confirm dimming, panel backgrounds, and header shadows look correct.

Made with Cursor

thomaspblock and others added 2 commits May 31, 2026 14:36
@thomaspblock @cursoragent
Fix desktop right panel chrome overlap
be0d9bd 
Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock @cursoragent
Keep side panel header below top chrome at narrow widths
5472783 
Overlay-mode side panels (agent activity, thread, profile) started at the
top of the viewport, so their header collided with the global search bar
and channel actions when the window was narrow. Anchor overlay panels
below the top chrome and restore the agent activity header layout so the
global channel buttons stay pinned to the window's right edge.

Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock thomaspblock requested a review from a team as a code owner June 1, 2026 12:44
@thomaspblock

thomaspblock commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author
overlay.mp4

@thomaspblock @cursoragent
fix: lower inbox pane header z-index to unblock search result clicks
965f11d 
The InboxDetailPane and InboxListPane headers were at z-50, which sat
above the TopbarSearch results dropdown after the global chrome z-index
was normalized to z-40. This caused the "opens channel matches from
search" E2E test to fail because the inbox header intercepted pointer
events on search results.

Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock

thomaspblock commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

Found a few more issues, will let you know when it's done.

thomaspblock and others added 4 commits June 1, 2026 12:58
@thomaspblock @cursoragent
Fix desktop panel chrome layout
7a43fc5 
Keep responsive side panels aligned with the app chrome while preserving blurred headers, composer spacing, and stable hover behavior.

Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock @cursoragent
Merge origin/main into right-side
5866a97 
Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock @cursoragent
fix(desktop): restore strong panel close affordances
6090c18 
Bring thread/profile/activity close buttons back to high-contrast styling and make subthread summary rows subtly interactive without shifting alignment.

Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock @cursoragent
fix(home): add narrow inbox detail takeover flow
50dd5c6 
Show inbox list first on small widths, switch to detail on selection, and provide a back button in the detail header to return to the list.

Co-authored-by: Cursor <cursoragent@cursor.com>
@wesbillman

wesbillman commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

@thomaspblock I'm still seeing some overlap when using the activity sidebar, do you see this on your end?
Screenshot 2026-06-01 at 12 35 45 PM
Screenshot 2026-06-01 at 12 36 28 PM

Also, on small widths, it seems like the activity fully covers the chat, is that expected?

Screenshot 2026-06-01 at 12 36 02 PM

@thomaspblock

thomaspblock commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

Still working on it. Will let you know once it's good to check.

@wesbillman

wesbillman commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator

Sorry I jumped the gun! You can set this PR to Draft as well if you want me to ignore. Or I can just wait on review for your PRs until you lemme know 👍

@thomaspblock thomaspblock marked this pull request as draft June 1, 2026 19:46
@thomaspblock

thomaspblock commented Jun 1, 2026

Copy link
Copy Markdown
Collaborator Author

Ahh super. I switched to draft, good to know. I will ask the agent to set that when it pushes.

thomaspblock and others added 6 commits June 1, 2026 17:56
@thomaspblock @cursoragent
fix(desktop): refine responsive panel headers
07031d1 
Align narrow panel headers with the two-column layout and keep agent sheets close-only while preserving avatar identity and active controls.

Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock @cursoragent
fix(desktop): polish agent activity display
058c33a 
Left-align agent activity transcript entries, show requester avatars for prompt messages, and prevent inline activity avatars from clipping below the composer.

Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock @cursoragent
fix(desktop): refine responsive detail panels
eecc3b6 
Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock
Merge remote-tracking branch 'origin/main' into right-side
c806174
@thomaspblock @cursoragent
fix(desktop): systematize panel layering and width observation
6bb68a0 
Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock @cursoragent
fix(desktop): tune light theme modal overlays
c472d51 
Co-authored-by: Cursor <cursoragent@cursor.com>
@thomaspblock

thomaspblock commented Jun 2, 2026

Copy link
Copy Markdown
Collaborator Author
various-updates.mp4

@thomaspblock thomaspblock marked this pull request as ready for review June 2, 2026 12:22
@wesbillman wesbillman merged commit 5bed17a into main Jun 2, 2026
15 checks passed
@wesbillman wesbillman deleted the right-side branch June 2, 2026 14:37
@wesbillman wesbillman mentioned this pull request Jun 2, 2026
Merged
wesbillman added a commit that referenced this pull request Jun 2, 2026
@wesbillman
Desktop #806 follow-ups: panel/inbox fixes + top-bar backdrop (#814)
a25ca5d 
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co>
@wesbillman wesbillman mentioned this pull request Jun 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wesbillman wesbillman wesbillman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thomaspblock @wesbillman