fix(desktop): route notification clicks to thread context#790
Merged
Conversation
Signed-off-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com>
Signed-off-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com>
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Collaborator
|
@codex please review |
wesbillman
approved these changes
May 29, 2026
|
Codex Review: Didn't find any major issues. What shall we delve into next? ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 1, 2026
* origin/main: fix(desktop): route notification clicks to thread context (#790) chore(deps): update all non-major dependencies (#804) fix(deps): re-pin isomorphic-git patch to 1.38.3 (#807) chore(deps): update dependency @tanstack/react-query to v5.100.14 (#805) Fix desktop glass chrome and inbox previews (#793) refactor(just): slim down mobile-dev to just run Flutter (#801) Signed-off-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
threadRootIdthrough desktop notification targets and existingsprout://messagedeep link navigationthreadRootIdto channel route search params and fetch it with the target event for route backfillTesting
pnpm --dir desktop typecheckpnpm --dir desktop exec biome check src/app/AppShell.tsx src/app/navigation/resolveSearchHitDestination.ts src/app/navigation/useAppNavigation.ts src/app/routes/ChannelRouteScreen.tsx 'src/app/routes/channels.$channelId.posts.$postId.tsx' 'src/app/routes/channels.$channelId.tsx' src/features/channels/ui/ChannelScreen.tsx src/features/notifications/lib/desktop.ts src/features/notifications/use-feed-desktop-notifications.ts src/shared/api/types.ts src/shared/ui/markdown.tsx src/shared/useMessageDeepLinks.tspnpm --dir desktop testpnpm --dir desktop exec playwright test tests/e2e/profile.spec.ts -g "notification settings drive" --project=integration#engineeringopens the message thread panel and contains the depth-4 target. Result: root-only route fetch is enough because existinguseLoadMissingAncestorsbackfills intermediate ancestors; no new ancestor walker needed in this patch.Notes
Pre-push hook was bypassed because the repo's broader
desktop-tauri-test/desktop-tauri-clippyhook fails in unrelated Rust code on this machine/toolchain withuse of unstable library feature round_char_boundaryindesktop/src-tauri/src/commands/agent_discovery.rs.@dawn please review the route backfill/cache-preservation shape.