Skip to content

feat(desktop): open profile panel from MembersSidebar rows #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 2 commits into from
Jun 11, 2026
Merged

feat(desktop): open profile panel from MembersSidebar rows #962

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc74cc6
feat(desktop): open profile panel from MembersSidebar rows
tellaho Jun 10, 2026
5c1197a
fix(desktop): don't offer profile open from member rows in forums
tellaho Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions desktop/src/features/channels/ui/MembersSidebar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ import {
DialogHeader,
DialogTitle,
} from "@/shared/ui/dialog";
import { useProfilePanel } from "@/shared/context/ProfilePanelContext";
import { useFeedbackToasts } from "@/shared/hooks/useToastEffect";
import { normalizePubkey } from "@/shared/lib/pubkey";
import {
Expand Down Expand Up @@ -161,6 +162,21 @@ export function MembersSidebar({

useFeedbackToasts(actionNoticeMessage, actionErrorMessage);

const { openProfilePanel } = useProfilePanel();
// UserProfilePanel only renders inside ChannelPane, which forums replace
// with ForumView — opening there would close the sheet and show nothing.
const isForumChannel = channel?.channelType === "forum";
const handleOpenProfile = React.useMemo(
() =>
openProfilePanel && !isForumChannel
? (pubkey: string) => {
onOpenChange(false);
openProfilePanel(pubkey);
}
: undefined,
[isForumChannel, onOpenChange, openProfilePanel],
);

const [editRespondToAgent, setEditRespondToAgent] =
React.useState<ManagedAgent | null>(null);

Expand Down Expand Up @@ -192,6 +208,7 @@ export function MembersSidebar({
onManagedAgentAction={(agent) => {
void handleAgentLifecycleAction(agent);
}}
onOpenProfile={handleOpenProfile}
onRemoveMember={handleRemoveMember}
onViewActivity={
onViewActivity
Expand Down
116 changes: 67 additions & 49 deletions desktop/src/features/channels/ui/MembersSidebarMemberCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ type MembersSidebarMemberCardProps = {
onChangeRole: (member: ChannelMember, role: string) => void;
onEditRespondTo?: (agent: ManagedAgent) => void;
onManagedAgentAction: (agent: ManagedAgent) => void;
onOpenProfile?: (pubkey: string) => void;
onRemoveMember: (member: ChannelMember) => void;
onViewActivity?: (pubkey: string) => void;
presenceStatus?: PresenceStatus | null;
Expand Down Expand Up @@ -97,6 +98,7 @@ export function MembersSidebarMemberCard({
onChangeRole,
onEditRespondTo,
onManagedAgentAction,
onOpenProfile,
onRemoveMember,
onViewActivity,
presenceStatus,
Expand All @@ -112,60 +114,76 @@ export function MembersSidebarMemberCard({
? Boolean(managedAgent) || canRemoveMember || canViewActivity
: canRemoveMember || canChangeRole;

const memberIdentity = (
<>
<div className="relative shrink-0">
<ProfileAvatar
avatarUrl={profileAvatarUrl ?? null}
className="h-9 w-9 text-[11px] shadow-none"
iconClassName="h-4 w-4"
label={memberAvatarLabel}
/>
{presenceStatus ? (
<span
className="absolute -bottom-0.5 -right-0.5 flex h-3.5 w-3.5 items-center justify-center rounded-full bg-background"
data-testid={`sidebar-member-presence-${member.pubkey}`}
>
<PresenceDot className="h-2 w-2" status={presenceStatus} />
</span>
) : null}
</div>
<div className="min-w-0">
<div className="flex items-center gap-1.5">
<p className="truncate text-sm font-medium leading-5">
{memberLabel}
</p>
<Badge className="shrink-0" variant="secondary">
{roleLabel}
</Badge>
{managedAgent ? (
<>
<Badge
className="shrink-0"
data-testid={`sidebar-managed-agent-status-${member.pubkey}`}
variant="secondary"
>
{formatManagedAgentStatus(managedAgent)}
</Badge>
<Badge
className="shrink-0"
data-testid={`sidebar-managed-agent-respond-to-${member.pubkey}`}
variant="outline"
>
{formatRespondToLabel(managedAgent)}
</Badge>
</>
) : null}
</div>
<p className="truncate font-mono text-[10px] text-muted-foreground/50">
{truncatePubkey(member.pubkey)}
</p>
</div>
</>
);

return (
<div
className="group flex items-center justify-between gap-3 rounded-lg px-3 py-2 transition-colors hover:bg-muted/40"
data-testid={`sidebar-member-${member.pubkey}`}
>
<div className="flex min-w-0 items-center gap-3">
<div className="relative shrink-0">
<ProfileAvatar
avatarUrl={profileAvatarUrl ?? null}
className="h-9 w-9 text-[11px] shadow-none"
iconClassName="h-4 w-4"
label={memberAvatarLabel}
/>
{presenceStatus ? (
<span
className="absolute -bottom-0.5 -right-0.5 flex h-3.5 w-3.5 items-center justify-center rounded-full bg-background"
data-testid={`sidebar-member-presence-${member.pubkey}`}
>
<PresenceDot className="h-2 w-2" status={presenceStatus} />
</span>
) : null}
</div>
<div className="min-w-0">
<div className="flex items-center gap-1.5">
<p className="truncate text-sm font-medium leading-5">
{memberLabel}
</p>
<Badge className="shrink-0" variant="secondary">
{roleLabel}
</Badge>
{managedAgent ? (
<>
<Badge
className="shrink-0"
data-testid={`sidebar-managed-agent-status-${member.pubkey}`}
variant="secondary"
>
{formatManagedAgentStatus(managedAgent)}
</Badge>
<Badge
className="shrink-0"
data-testid={`sidebar-managed-agent-respond-to-${member.pubkey}`}
variant="outline"
>
{formatRespondToLabel(managedAgent)}
</Badge>
</>
) : null}
</div>
<p className="truncate font-mono text-[10px] text-muted-foreground/50">
{truncatePubkey(member.pubkey)}
</p>
</div>
</div>
{onOpenProfile ? (
<button
aria-label={`Open profile for ${memberLabel}`}
className="flex min-w-0 flex-1 items-center gap-3 text-left focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 focus-visible:ring-offset-background rounded-md"
data-testid={`sidebar-member-open-profile-${member.pubkey}`}
onClick={() => onOpenProfile(member.pubkey)}
type="button"
>
{memberIdentity}
</button>
) : (
<div className="flex min-w-0 items-center gap-3">{memberIdentity}</div>
)}
{hasActions ? (
<MemberActionsMenu
canChangeRole={canChangeRole}
Expand Down