Fix channel visibility controls#940
Merged
Merged
Conversation
Split the channel settings detail and lifecycle save paths so their pending state no longer overlaps. Default a blank ephemeral timeout to 1d when enabling ephemeral channels, and accept relay visibility snapshots that use the visibility tag shape when mapping channel details. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Collaborator
Author
Verification screenshotsLifecycle save is pending while details save stays idle: Private + Ephemeral persist after closing/reopening channel settings, with blank timeout defaulted to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
1d/ttlSeconds: 86400when enabling ephemeral channels["visibility", "private"|"open"]plus TTL tagsTesting
cd desktop && ../bin/pnpm buildcd desktop && ../bin/pnpm exec playwright test tests/e2e/channels.spec.ts -g 'manage channel updates visibility and ephemeral lifecycle independently' --project=smokecd desktop && ../bin/pnpm exec playwright test tests/e2e/channel-controls-screenshots.spec.ts -g '07|08' --project=smokecd desktop && ../bin/pnpm checksrc/shared/features/useFeatureEnabled.ts:76cd desktop/src-tauri && ../../bin/cargo test nostr_convert./bin/just desktop-test./bin/just desktop-tauri-fmt-checkScreenshots
Will add the verification screenshots in a follow-up PR comment.