fix(desktop): improve model picker message and runtime dropdown clarity#778
Merged
Merged
Conversation
ModelPicker showed "This agent uses the runtime's default model" even when a custom model was explicitly configured (e.g., kgoose-gpt-5-5). Now shows the model name with a "switching not supported" note when the runtime doesn't enumerate models via ACP. AddChannelBotDialog's Runtime dropdown had no indication that personas with a preferred runtime would override the selection. Added conditional helper text that surfaces this when relevant.
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



The model picker dropdown in the agent list showed "This agent uses the runtime's default model" even when a custom model was explicitly set on the agent (e.g.,
kgoose-gpt-5-5via Databricks). This happened because the message was gated solely on whether the ACP runtime supports model switching (supportsSwitching), without checking whetheragent.modelwas already configured. The dropdown now shows the configured model name with a "switching not supported" note when the runtime doesn't enumerate models via ACP, and falls back to the original default-model message only when no model is set.The "Add agents" channel dialog's Runtime dropdown had no indication that personas with a preferred runtime would silently override the dropdown selection. Added conditional helper text: when any selected persona has a
providerset, the text explains that those personas will use their own runtime; otherwise it shows a generic "default runtime" note.ModelPicker.tsx— split the!supportsSwitchingbranch to checkagent.modelbefore choosing the messageAddChannelBotDialog.tsx— added<p>helper text after the Runtime<DropdownMenu>, conditional onselectedPersonas.some(p => p.provider)