desktop: float unread indicator + fix sidebar scroll jump#777
Merged
Conversation
- Remove bordered pill styling from MoreUnreadButton - Use bg-primary (accent color) to match the unread dot - Position absolutely over channel list so it floats - Add position prop (top/bottom) for directional placement Signed-off-by: Wes <wesbillman@users.noreply.github.com>
TanStack Router's scroll restoration captures all scroll events including the sidebar. When navigating between channels, it would restore the sidebar to a stale position. Add a useSidebarScrollLock hook that tracks the sidebar's scrollTop and re-applies it in a layout effect after pathname changes, preventing the jump. Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Float unread indicator with accent background
bg-primary(accent color) to match the unread dotFix sidebar scroll jump on channel selection
useSidebarScrollLockhook that subscribes to the router's event system:Files changed
desktop/src/features/sidebar/lib/useSidebarScrollLock.ts(new)desktop/src/features/sidebar/ui/AppSidebar.tsxdesktop/src/features/sidebar/ui/MoreUnreadButton.tsx