feat(desktop): redesign status UI with full emoji picker and presence sub-menu#760
Merged
Conversation
… sub-menu
- ProfilePopover: surface current presence inline (dot + label) and the
user-set status (emoji + text) in the identity block. Replace the two
large 'Set yourself as away/offline' rows with a single 'Change
presence' disclosure that opens a nested right-side popover.
- SetStatusDialog: drop the hardcoded 8-emoji strip; users can now pick
any emoji via emoji-mart. Keep the preset chips ('In a meeting',
'Commuting', etc.) as quick-pick. Add a small ✕ overlay to clear the
picked emoji.
- Use PopoverPrimitive.Content directly (no Portal) for the picker so it
renders inside the Dialog's focus trap — keeps emoji-mart search and
focus-return semantics correct.
- Update profile e2e to click the new disclosure before each presence
selection.
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
- Open the presence sub-menu on hover (with click toggle for keyboard); drop the focus-driven open that caused a flicker loop on close → focus-restore → reopen. - Replace static "Change presence" label with the live presence (Online/Away/Offline/etc.) so the row reflects current state. - Remove duplicate "Clear status" entry from the popover; the Update Status dialog already exposes its own clear control. - Add stable testid for the presence trigger and update e2e selectors. Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Collaborator
Author
|
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reworks the user status UI per Wes's feedback in the screenshots:
User menu (
ProfilePopover) — the two large "Set yourself as away" / "Set yourself as offline" rows are gone. The identity block now surfaces:@nip05· presence dot + label{emoji} {text}(only when a status is set)Presence selection moved into a single disclosure row that opens a nested right-side popover with the three states. The row label shows the live presence (Online / Away / Offline / etc.) with a chevron, not a static "Change presence" string. The sub-menu opens on hover (with click toggle for keyboard) — focus-driven open was dropped because Radix's focus restore on close caused a flicker loop. Existing
data-testid="profile-popover-status-{status}"ids preserved; trigger gainsprofile-popover-presence-trigger.Set status dialog — the hardcoded 8-emoji strip is replaced with a full
emoji-martpicker. Preset chips (In a meeting,Commuting, etc.) stay as quick-pick. A small ✕ overlay clears the picked emoji without touching the text. The dialog has its own Clear status button, so the duplicate one in the popover was removed.Notes
PopoverPrimitive.Contentdirectly (no Portal) so it renders inside the Dialog subtree. Otherwise Radix Dialog's focus trap blocks emoji-mart's search input.publishUserStatus(text, emoji)already accepts arbitrary emoji.profile.spec.tsupdated to click the new disclosure (now via testid) before each presence selection.Tests
pnpm --filter sprout typecheck✅pnpm --filter sprout lint✅pnpm --filter sprout build✅