feat(desktop): notification sound + sender names in titles#501
Merged
Conversation
…titles Play a custom sound (desktop-notification.mp3) when desktop notifications fire, with an in-app toggle in Settings > Notifications. OS notification sound is suppressed via silent:true to avoid double-ding. Feed notification titles now include sender display names (e.g. "Kalvin mentioned you in #general") and DM titles show participant names instead of generic "Direct message". Sender profiles are batch-fetched and the notification effect defers dispatch until profiles load to ensure names are present. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ormat Tests expected the old "@Mention in #channel" title format but our PR now includes sender names, e.g. "alice mentioned you in #general". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When the profile batch query cannot resolve a display name for the
sender (e.g. no kind:0 event on the relay), resolveUserLabel falls
back to a truncated pubkey like "953d3363…001f". This produced
notification titles like "953d3363…001f mentioned you in #channel".
Now we detect the truncated-pubkey fallback and pass undefined as
senderName, so notificationTitle uses the generic format instead
("@Mention in #channel"). Real display names still appear when
profiles are available.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
desktop-notification.mp3) when desktop notifications fire, controlled by a new Notification sound toggle in Settings > Notifications (defaults on, gated behind desktop alerts)silent: trueon the Notification constructor to prevent double-ding (matches Slack/Discord behavior)useUsersBatchQueryand the notification effect defers dispatch until profiles load to ensure names are presentTest plan
🤖 Generated with Claude Code