docs: AGENTS.md accuracy pass — verified against every line of code#235
Merged
Conversation
Fixes factual errors and gaps in the AI agent contributor guide:
- MySQL → Postgres (3 occurrences) — confirmed via sqlx features, docker-compose, .env
- Add 3 missing crates: sprout-sdk, sprout-media, sprout-cli (17 total)
- MCP pattern: 'proxy REST' → 'dual transport' (WS writes + REST reads),
add relay_client.rs pointer
- just ci description: add desktop lint (Biome) to the list
- unwrap/expect rule: rephrase as contributor policy ('Do not introduce new')
- E2E test list: add 3 missing files (media, media_extended, nostr_interop)
- Fix e2e_nostr_interop.rs description: NIP-50/NIP-10/NIP-17, not NIP-28
Every claim verified against source. Crossfire reviewed by Claude Opus
and GPT-5.4 (Codex) — both APPROVE at 9/10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Comprehensive accuracy pass on
AGENTS.md, the AI agent contributor guide. Every claim verified against the actual codebase by multiple independent verification agents, then crossfire-reviewed by Claude Opus and GPT-5.4 (Codex) — both approved at 9/10.Changes
sqlxfeatures,docker-compose.yml,.env.examplesprout-sdk,sprout-media,sprout-cli(14 → 17 total)relay_client.rspointer.just cidescriptionunwrap/expectrulee2e_media.rs,e2e_media_extended.rs,e2e_nostr_interop.rs(5 → 8 total)e2e_nostr_interop.rsdescriptionVerification method
Three independent verification delegates checked claims against source:
Two-round crossfire review:
Follow-ups (out of scope)
CONTRIBUTING.mdstill references MySQL in its prerequisites tableARCHITECTURE.mdhas stale LOC counts and technical details (PR Codebase cleanup: DRY, error handling, decomposition, docs #220 addressed those but was closed)