Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 29 additions & 0 deletions desktop/src/features/messages/lib/messageLink.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import {
buildMessageLink,
isMessageLink,
parseMessageLink,
resolveMessageLinkRenderTarget,
} from "./messageLink.ts";

const CHANNEL = "f570339f-8f8a-4e08-a779-8d954aa44109";
Expand Down Expand Up @@ -118,3 +119,31 @@ test("isMessageLink matches buzz://message and legacy buzz://message", () => {
assert.equal(isMessageLink(undefined), false);
assert.equal(isMessageLink(""), false);
});

test("resolveMessageLinkRenderTarget distinguishes autolinks from labeled links", () => {
const href = `buzz://message?channel=${CHANNEL}&id=${MESSAGE}`;

assert.deepEqual(resolveMessageLinkRenderTarget({ href, label: href }), {
kind: "pill",
link: {
channelId: CHANNEL,
messageId: MESSAGE,
threadRootId: null,
},
});
assert.deepEqual(resolveMessageLinkRenderTarget({ href, label: "message" }), {
kind: "label",
link: {
channelId: CHANNEL,
messageId: MESSAGE,
threadRootId: null,
},
});
assert.deepEqual(
resolveMessageLinkRenderTarget({
href: "https://example.com",
label: href,
}),
{ kind: "none" },
);
});
31 changes: 31 additions & 0 deletions desktop/src/features/messages/lib/messageLink.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,3 +102,34 @@ export function isMessageLink(href: string | undefined | null): boolean {
if (!href) return false;
return href.startsWith("buzz://message?") || href === "buzz://message";
}

type MessageLinkRenderInput = {
href: string;
label: string;
};

export type MessageLinkRenderTarget =
| { kind: "pill"; link: ParsedMessageLink }
| { kind: "label"; link: ParsedMessageLink }
| { kind: "none" };

/**
* Centralizes how markdown-rendered anchors map to message-link UI. Both
* CommonMark autolinks (`<buzz://message?...>`) and explicitly labeled links
* arrive as anchors; autolinks have label === href and should render as pills,
* while intentionally labeled links keep their label.
*/
export function resolveMessageLinkRenderTarget({
href,
label,
}: MessageLinkRenderInput): MessageLinkRenderTarget {
if (!isMessageLink(href)) return { kind: "none" };

const parsed = parseMessageLink(href);
if (!parsed.ok) return { kind: "none" };

return {
kind: label === href ? "pill" : "label",
link: parsed.value,
};
}
5 changes: 5 additions & 0 deletions desktop/src/shared/ui/markdown.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -471,6 +471,11 @@ test("messageLinkUrlTransform: preserves buzz://message href", () => {
assert.match(html, /href="buzz:\/\/message\?channel=abc&(?:amp;)?id=xyz"/);
});

test("messageLinkUrlTransform: preserves buzz://message autolink href", () => {
const html = renderMarkdown("<buzz://message?channel=abc&id=xyz>");
assert.match(html, /href="buzz:\/\/message\?channel=abc&(?:amp;)?id=xyz"/);
});

test("messageLinkUrlTransform: preserves buzz://message href with thread", () => {
const html = renderMarkdown(
"[link](buzz://message?channel=c1&id=m1&thread=t1)",
Expand Down
109 changes: 75 additions & 34 deletions desktop/src/shared/ui/markdown.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import { useAppNavigation } from "@/app/navigation/useAppNavigation";
import {
isMessageLink,
parseMessageLink,
resolveMessageLinkRenderTarget,
type ParsedMessageLink,
} from "@/features/messages/lib/messageLink";
import { UserProfilePopover } from "@/features/profile/ui/UserProfilePopover";
Expand Down Expand Up @@ -79,6 +80,14 @@ type ImetaEntry = {

type ImetaLookup = Map<string, ImetaEntry>;

type MessageLinkPillProps = {
channels: Channel[];
href: string;
interactive: boolean;
link: ParsedMessageLink;
onOpenMessageLink: (link: ParsedMessageLink) => void;
};

let shikiHighlighter: HighlighterGeneric<BundledLanguage, BundledTheme> | null =
null;
let shikiInitPromise: Promise<void> | null = null;
Expand Down Expand Up @@ -1252,6 +1261,46 @@ function getCodeBlockText(children: React.ReactNode) {
return getReactNodeText(children).replace(/\n$/, "");
}

function MessageLinkPill({
channels,
href,
interactive,
link,
onOpenMessageLink,
}: MessageLinkPillProps) {
const channel = channels.find((c) => c.id === link.channelId);
const channelLabel = channel?.name ?? "channel";
const shortId = link.messageId.slice(0, 6);
const label = (
<>
#{channelLabel} · {shortId}
</>
);

if (!interactive) {
return <span data-message-link="">{label}</span>;
}

return (
<button
type="button"
data-message-link=""
aria-label={`Open message in ${channelLabel}`}
title={href}
className={cn(
"cursor-pointer",
MENTION_CHIP_BASE_CLASSES,
MENTION_CHIP_HOVER_CLASSES,
)}
onClick={() => {
onOpenMessageLink(link);
}}
>
{label}
</button>
);
}

function InlineEmojiPopover({
alt,
resolvedSrc,
Expand Down Expand Up @@ -1788,18 +1837,32 @@ function createMarkdownComponents(
// Intercept `buzz://message?channel=…&id=…` links so a click navigates
// in-app instead of opening the URL in the OS browser. http(s) links
// continue to use the existing target="_blank" behavior.
if (isMessageLink(href)) {
const parsed = parseMessageLink(href ?? "");
if (parsed.ok) {
const target = parsed.value;
if (href) {
const messageLinkTarget = resolveMessageLinkRenderTarget({
href,
label: getReactNodeText(children),
});
if (messageLinkTarget.kind !== "none") {
if (messageLinkTarget.kind === "pill") {
return (
<MessageLinkPill
channels={runtimeRef.current.channels}
href={href}
interactive={interactive}
link={messageLinkTarget.link}
onOpenMessageLink={onOpenMessageLink}
/>
);
}

return (
<a
{...props}
className="font-medium text-primary underline underline-offset-4 transition-colors hover:text-primary/80 cursor-pointer"
href={href}
onClick={(event) => {
event.preventDefault();
onOpenMessageLink(target);
onOpenMessageLink(messageLinkTarget.link);
}}
>
{children}
Expand Down Expand Up @@ -2095,36 +2158,14 @@ function createMarkdownComponents(
return <span data-message-link="">{href}</span>;
}

const { channelId, messageId } = parsed.value;
const channel = channels.find((c) => c.id === channelId);
const channelLabel = channel?.name ?? "channel";
const shortId = messageId.slice(0, 6);

if (!interactive) {
return (
<span data-message-link="">
#{channelLabel} · {shortId}
</span>
);
}

return (
<button
type="button"
data-message-link=""
aria-label={`Open message in ${channelLabel}`}
title={href}
className={cn(
"cursor-pointer",
MENTION_CHIP_BASE_CLASSES,
MENTION_CHIP_HOVER_CLASSES,
)}
onClick={() => {
onOpenMessageLink(parsed.value);
}}
>
#{channelLabel} · {shortId}
</button>
<MessageLinkPill
channels={channels}
href={href}
interactive={interactive}
link={parsed.value}
onOpenMessageLink={onOpenMessageLink}
/>
);
},
} as Components;
Expand Down
Loading