Skip to content

Fix display names flashing to pubkeys when loading older messages #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wesbillman merged 1 commit into from
Jun 19, 2026
Merged

Fix display names flashing to pubkeys when loading older messages #1137

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion desktop/src/features/profile/hooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
import * as React from "react";
import { useMutation, useQuery, useQueryClient } from "@tanstack/react-query";
import {
keepPreviousData,
useMutation,
useQuery,
useQueryClient,
} from "@tanstack/react-query";

import {
getProfile,
Expand Down Expand Up @@ -281,6 +286,10 @@ export function useUsersBatchQuery(
enabled,
queryKey: ["users-batch", ...normalizedPubkeys],
queryFn: () => getUsersBatch(normalizedPubkeys),
// Loading older messages grows the pubkey set, which changes this query's
// key entirely. Without this, already-resolved authors would flash back
// to their raw pubkey while the larger batch refetches.
placeholderData: keepPreviousData,
staleTime: 60_000,
gcTime: 5 * 60 * 1_000,
});
Expand Down