feat(desktop): unify unread pills into one shared UnreadPill component#1111
Merged
Conversation
The message timeline and sidebar each rolled their own unread "jump" affordance: the timeline-top pill (outline/primary), the timeline-bottom "jump to latest" pill (muted/gray), and the sidebar "N more unread" pills (solid primary). Extract a single UnreadPill component styled like the timeline-top pill and use it in all four spots — message area top/bottom and sidebar top/bottom — so they read as one family. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
CI's biome check flagged a multi-line emitMockMessage call that the formatter collapses to a single line. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
The unify screenshot spec existed only to capture PR images, which are now attached to the PR. Its assertions were thin and it relied on fixed waitForTimeout sleeps; the same testids are already exercised by the existing unread-pill and onboarding e2e specs, and the auto-scroll logic is covered by timelineSnapshot unit tests. Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Unify the unread "jump" affordances into one shared
UnreadPillcomponent, styled like the message-timeline pill (outline / primary). Previously three different treatments existed; this collapses the four pill spots into a single component so they read as one family.The four spots (after)
Before → after
Two spots changed visually:
Message-area bottom was a muted gray pill:
Sidebar was a solid-blue pill labeled "N more unread":
Changes
desktop/src/shared/ui/UnreadPill.tsx— outline-primary pill (border-primary/40 bg-primary/10 text-primary, rounded-full, arrow + label), with aunreadCountLabel(count)helper for consistent "N new message(s)" pluralization.MoreUnreadButtoncollapsed to a thin positioning wrapper aroundUnreadPill.MessageTimelinepills (top + bottom) now renderUnreadPill; deadArrowUp/ArrowDown/Buttonimports removed.unread-pill-unify-screenshots.spec.ts) covering all four spots.The per-row sidebar dot (one boolean indicator per channel row) is intentionally left untouched — it's a different job and out of scope.
Testing
typecheck,pnpm check(biome + file-size + px-text): cleanunread-pill-screenshots.spec.ts(no regression) + newunread-pill-unify-screenshots.spec.ts, all pass