feat: surface base + persona system prompts in observer feed#1103
Merged
Conversation
The agent observer Prompt context panel parsed only per-turn session/prompt frames, so the base and persona system prompts — which ride session/new's systemPrompt field — never appeared. The data was already on the wire; the desktop transcript builder just never read the session/new frame. Frame the modern combined systemPrompt so each present prompt carries its own [Base]/[System] header (reusing queue::base_section as the single source of truth) instead of a bare newline join that erased the boundary. The desktop arm splits it deterministically rather than via the generic section parser so embedded bracket lines and oversize-elided headers can never drop a label or inflate the section count. Key the item per channel-session — the session/new frame predates session creation and carries no session id. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
The both-present match arm exceeded the line-length limit; rustfmt wraps the format! call across lines. No behavior change. Co-authored-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 18, 2026
…te-response * origin/main: (194 commits) Fold agent core memory into the session system prompt (#1112) feat(cli): add patches and issues commands for NIP-34 git collaboration (#1073) fix(desktop): stop random timeline message loss + page reconnect replay (#1105) Update README.md fix(desktop): keep thread replies from scrolling channel (#1109) fix(buzz-acp): accept siblings under allowlist author gate (#1108) feat(deploy): add production Helm chart for Buzz (#990) fix(desktop): keep MembersSidebar input usable while an add is in flight (#1106) chore(release): release version 0.3.25 (#1102) fix(desktop): stop dimming deferred message lists (#1104) Smooth channel loading: single-surface timeline state machine (#1099) feat: surface base + persona system prompts in observer feed (#1103) ci: move reminder e2e to a dedicated backend-integration job (#1098) fix: give agent-observer sub a replay-capable limit (#1100) fix: make managed-agent spawn and teardown portable to Windows (#1097) fix(desktop): constrain message timeline width with min-w-0 (#1092) feat(desktop): reminders notifications, snooze, overlay, and inbox view mode (#1093) feat(prompt): add memory hygiene and hoist universal engineering discipline to base prompt (#1085) fix(desktop): correct thread-unread badge flicker, stale clear, phantom count, mention gate, and nested count (#1080) Fix mention chip alignment (#1094) ... # Conflicts: # crates/buzz-cli/src/commands/workflows.rs
tlongwell-block
pushed a commit
that referenced
this pull request
Jun 18, 2026
…te-response * origin/main: (194 commits) Fold agent core memory into the session system prompt (#1112) feat(cli): add patches and issues commands for NIP-34 git collaboration (#1073) fix(desktop): stop random timeline message loss + page reconnect replay (#1105) Update README.md fix(desktop): keep thread replies from scrolling channel (#1109) fix(buzz-acp): accept siblings under allowlist author gate (#1108) feat(deploy): add production Helm chart for Buzz (#990) fix(desktop): keep MembersSidebar input usable while an add is in flight (#1106) chore(release): release version 0.3.25 (#1102) fix(desktop): stop dimming deferred message lists (#1104) Smooth channel loading: single-surface timeline state machine (#1099) feat: surface base + persona system prompts in observer feed (#1103) ci: move reminder e2e to a dedicated backend-integration job (#1098) fix: give agent-observer sub a replay-capable limit (#1100) fix: make managed-agent spawn and teardown portable to Windows (#1097) fix(desktop): constrain message timeline width with min-w-0 (#1092) feat(desktop): reminders notifications, snooze, overlay, and inbox view mode (#1093) feat(prompt): add memory hygiene and hoist universal engineering discipline to base prompt (#1085) fix(desktop): correct thread-unread badge flicker, stale clear, phantom count, mention gate, and nested count (#1080) Fix mention chip alignment (#1094) ... Co-authored-by: Tyler Longwell <tlongwell@squareup.com> Signed-off-by: Tyler Longwell <tlongwell@squareup.com> # Conflicts: # crates/buzz-cli/src/commands/workflows.rs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agent observer "Prompt context" panel showed only the per-turn sections (core memory, the triggering event) and never the base or persona system prompt — Will's screenshot showed "2 sections" with both system prompts absent. The data was already on the wire:
session/newemits anacp_writeobserver frame carryingparams.systemPrompt. The desktop transcript builder simply never parsed thesession/newframe.This surfaces the base + persona prompts as one collapsible "System prompt" metadata item with two labeled sub-sections (
Base,System) — both are parts of the singlesystemPromptfield sent to the LLM, so they're grouped under one item.Harness (
crates/buzz-acp/src/pool.rs)The modern path (
protocol_version >= 2) joined base + persona with a bare\n\n, erasing the boundary. The newframed_system_prompthelper frames each present prompt with its own header, reusingqueue::base_sectionas the single source of truth for[Base]framing:[Base]\n{base}\n\n[System]\n{persona}[Base]\n{base}[System]\n{persona}(a bare persona would be mislabeledBasedownstream)NoneThe legacy path (
protocol_version < 2) is unchanged — it already frames[Base]/[System]in the per-turn message.Desktop (
agentSessionTranscript.ts,agentSessionTranscriptHelpers.ts)A new
method === "session/new"arm in theacp_writebranch parsesparams.systemPromptand emits the item via the existingupsertMetadatahelper. The split is deterministic (parseSystemPromptSections) rather than the generic section parser:\n[System]\nboundary; each labeled body is read literally.[...]lines inside a body never start a new section, so a persona containing a bracketed line can't inflate the section count.[System]header degrades to a single correctly-labeledBasesection (truncated body) — never a dropped label, never a lying count.The item is keyed
system-prompt:${ch}(per channel-session): thesession/newframe predates session creation and carries no session id, and the frame fires once per channel-session lifetime, so a re-created session correctly replaces the prior item. No change toPromptSection/TranscriptItemtypes.Tests
framed_system_prompt: both-present, base-only, persona-only, neither.parseSystemPromptSections: both-present (2 sections), base-only (1Base), persona-only (1System), embedded bracket lines stay literal, elided[System]header degrades to labeledBase, empty input -> no sections.