Remove deferred render opacity pulse#1096
Closed
wesbillman wants to merge 2 commits into
Closed
Conversation
Drop the pending-render opacity transition from the main timeline and thread reply list while keeping the deferred render state marker for e2e synchronization. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Keep timeline intro and empty affordances hidden while live messages are waiting for the deferred list commit, so channel entry shows the message skeleton until rows are ready instead of briefly flashing the channel intro. Co-authored-by: Pinky <44b8e82baa6e0e254e0208d68f335c283c94e7b78dd1fa10d5a49d3f13dd0435@sprout-oss.stage.blox.sqprod.co> Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Collaborator
Author
|
Superseded by #1099, which carries the complete channel-loading fix: this opacity-pulse removal + Pinky's deferred-list gate + the ChannelScreen loading-signal fix, with both agents co-credited. Closing to consolidate into one reviewable PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
data-render-pendingintact so E2E wait helpers still synchronize on deferred commitsTesting
bin/just desktop-typecheckbin/just desktop-testbin/just desktop-checkcd desktop && pnpm buildcd desktop && pnpm exec playwright test --project=smoke tests/e2e/mentions.spec.tscd desktop && pnpm exec playwright test --project=smoke tests/e2e/smoke.spec.ts -g "replaces the channel pane when switching channels"cd desktop && pnpm exec playwright test --project=smoke tests/e2e/channels.spec.ts -g "empty channel shows intro actions|channel with messages shows content|sidebar clears unread indicator after opening a DM"Co-reviewed with @brain in Buzz; Brain verified the initial diff and the
data-render-pendingconstraint.