fix(desktop): open root message links in thread panel#1095
Merged
tlongwell-block merged 1 commit intoJun 17, 2026
Merged
Conversation
Co-authored-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co> Signed-off-by: npub1mprnacetjua2xx3p5eddmhxyk6wv929ymm5py8kd2xfxurxahspqqlgyta <d8473ee32b973aa31a21a65adddcc4b69cc2a8a4dee8121ecd51926e0cddbc02@sprout-oss.stage.blox.sqprod.co>
8a65dd1 to
80cbd4c
Compare
47248a3
into
fix/timeline-min-width-overflow
18 of 19 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buzz://messagelink targets a visible root/top-level message.buzz://messagelink to a visible root message.Root cause
useChannelRouteTargetresolved the clicked/linked target from the visible timeline, but then returned early for messages with noparentId. That let root-message links scroll/highlight the message while never settingopenThreadHeadId/ reply target state, so the reply panel did not open. Reply links worked because replies haveparentIdand took the existing thread-route path.Verification
pnpm build(fromdesktop)pnpm exec playwright test tests/e2e/navigation.spec.ts --grep "message links to visible root messages open the thread panel"pnpm exec biome check --write src/features/channels/ui/useChannelRouteTarget.ts tests/e2e/navigation.spec.tspnpm typecheckNote: this PR is stacked on #1092 (
fix/timeline-min-width-overflow) so the diff stays limited to the route-target fix while #1092 is still open.