Skip to content

fix(release): replace hermit with native tool setup on Windows job #1018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wpfleger96 merged 2 commits into from
Jun 12, 2026
+16 −6
Merged

fix(release): replace hermit with native tool setup on Windows job #1018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b6171ba
fix(release): replace hermit with native tool setup on Windows job
Jun 12, 2026
3884557
fix(release): disable setup-node cache on Windows job to clear zizmor…
Jun 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 16 additions & 6 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -564,15 +564,25 @@
ref: ${{ github.event_name == 'push' && github.ref || inputs.ref }}
persist-credentials: false

- uses: cashapp/activate-hermit@e49f5cb4dd64ff0b0b659d1d8df499595451155a # v1
- uses: dtolnay/rust-toolchain@e081816240890017053eacbb1bdf337761dc5582 # 1.95.0

Check notice

Code scanning / zizmor

action functionality is already included by the runner Note

action functionality is already included by the runner
Comment thread
wpfleger96 marked this conversation as resolved.
Dismissed
with:
targets: ${{ env.TARGET }}

- name: Install desktop dependencies
shell: bash
run: just desktop-install-ci
- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4.4.0
Comment thread
github-advanced-security[bot] marked this conversation as resolved.
Fixed
with:
node-version: 24.14.0
# Disable dependency caching: a writable cache in this release workflow
# (contents: write, feeds a signed installer) is a poisoning vector. pnpm
# install runs uncached below.
package-manager-cache: false

- name: Add Rust target
- uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4.3.0
with:
version: 11.4.0

- name: Install desktop dependencies
shell: bash
run: rustup target add "$TARGET"
run: pnpm install --frozen-lockfile

- name: Patch version
shell: bash
Expand Down