Polish message reaction tray#1002
Conversation
eafbff9 to
c96a3c5
Compare
7664858 to
1373c1d
Compare
c96a3c5 to
500958b
Compare
1373c1d to
cc202fa
Compare
500958b to
4b005d6
Compare
cc202fa to
cccc86e
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cccc86e44e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
4b005d6 to
faf722f
Compare
cccc86e to
44bfd99
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44bfd99363
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
44bfd99 to
e2ffa3d
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e2ffa3ddea
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dcced71469
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| .filter( | ||
| (item) => !isCustomEmojiShortcode(item.emoji) || item.customEmojiUrl, | ||
| ), |
There was a problem hiding this comment.
When the first four stored recents are custom shortcodes that no longer exist in the workspace, useQuickReactionEmojis(4) has already applied the limit before this new filter runs, so this drops all four and the quick-reaction tray renders no buttons instead of falling back to the default emojis. Users can hit this after removing or renaming frequently used custom emoji; filter/prune stale custom entries before applying the limit, or backfill with defaults after this filter.
Useful? React with 👍 / 👎.
Stack 5/5. Depends on #1001.
Summary:
Checks:
pnpm --dir desktop exec biome check src/features/messages/ui/useQuickReactionEmojis.ts src/features/messages/ui/MessageActionBar.tsx src/features/messages/ui/MessageReactions.tsx src/features/messages/ui/SystemMessageRow.tsxpnpm --dir desktop typecheckgit diff --check origin/main..HEAD