-
Notifications
You must be signed in to change notification settings - Fork 8
fix(mithril): update script to match aggregator response #314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
It seems mithril aggregator api has changed its response and snapshot's digest is now under key .hash Signed-off-by: Roberto C. Morano <[email protected]>
📝 WalkthroughWalkthroughThe change modifies the snapshot parameter extraction in Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Pre-merge checks and finishing touches✅ Passed checks (2 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
bin/run-network (1)
33-33: SNAPSHOT_DIGEST now pulls.hash– behavior looks correct, name slightly misleadingSwitching the jq path from
.[0].digestto.[0].hashaligns with the stated change in the Mithril aggregator response and should make the download call use the correct snapshot identifier, assuming the client and aggregator versions are in sync.The only minor nit is that
SNAPSHOT_DIGESTis now populated from ahashfield, which can be confusing for future maintainers. If/when you next touch this script more broadly, consider renaming the variable and corresponding log messages to something likeSNAPSHOT_HASHfor clarity.Please double‑check against the current Mithril aggregator and
mithril-clientdocs thathashis the canonical field and thatcardano-db download <hash>is the expected CLI contract.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
bin/run-network(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
- GitHub Check: cubic · AI code reviewer
- GitHub Check: build (amd64)
- GitHub Check: build (arm64)
It seems mithril aggregator api has changed its response and snapshot's digest is now under key .hash
Summary by cubic
Update run-network to read the snapshot digest from the .hash field in the Mithril aggregator response. Fixes snapshot download by aligning the jq filter with the new API.
Written for commit 74a2125. Summary will update automatically on new commits.
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.