Skip to content

llm: Add test constants placement rule to testing skill#6726

Merged
SaintPatrck merged 1 commit intomainfrom
llm/build-test-verify_test-const-placement-rule
Mar 30, 2026
Merged

llm: Add test constants placement rule to testing skill#6726
SaintPatrck merged 1 commit intomainfrom
llm/build-test-verify_test-const-placement-rule

Conversation

@SaintPatrck
Copy link
Copy Markdown
Contributor

🎟️ Tracking

LLM tooling improvement — no Jira ticket.

📔 Objective

Add a "Test Constants Placement" section to the testing-android-code skill documenting the convention: declare test constants as top-level private const val at the bottom of the file, not inside companion object.

Document the convention of placing test constants as top-level
private const val at the bottom of the file rather than in
companion objects.
@github-actions github-actions bot added the t:llm Change Type - LLM related change (e.g. CLAUDE.md files) label Mar 27, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.16%. Comparing base (94e550d) to head (5558e8b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6726   +/-   ##
=======================================
  Coverage   86.16%   86.16%           
=======================================
  Files         840      840           
  Lines       59258    59258           
  Branches     8516     8516           
=======================================
  Hits        51060    51060           
  Misses       5244     5244           
  Partials     2954     2954           
Flag Coverage Δ
app-data 17.26% <ø> (ø)
app-ui-auth-tools 20.33% <ø> (ø)
app-ui-platform 15.72% <ø> (ø)
app-ui-vault 26.67% <ø> (ø)
authenticator 6.51% <ø> (ø)
lib-core-network-bridge 4.23% <ø> (ø)
lib-data-ui 0.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SaintPatrck SaintPatrck added ai-review Request a Claude code review ai-review-vnext Request a Claude code review using the vNext workflow and removed ai-review Request a Claude code review labels Mar 27, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 27, 2026

🤖 Bitwarden Claude Code Review

Overall Assessment: APPROVE

Documentation-only change adding a "Test Constants Placement" section to the testing-android-code skill. The new guidance documents the existing codebase convention: declare test constants as top-level private const val at the bottom of the file, not inside companion object. The section is well-placed between "Test File Organization" and "Test Naming" and is clear and actionable.

Code Review Details

No findings. Clean documentation addition with no code, security, or architectural concerns.

@SaintPatrck SaintPatrck marked this pull request as ready for review March 27, 2026 18:34
@SaintPatrck SaintPatrck requested a review from a team as a code owner March 27, 2026 18:34
@SaintPatrck SaintPatrck requested review from a team and david-livefront March 27, 2026 18:34
@SaintPatrck SaintPatrck enabled auto-merge March 27, 2026 18:42
@SaintPatrck SaintPatrck added this pull request to the merge queue Mar 30, 2026
Merged via the queue into main with commit cc7ce34 Mar 30, 2026
33 of 34 checks passed
@SaintPatrck SaintPatrck deleted the llm/build-test-verify_test-const-placement-rule branch March 30, 2026 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-review-vnext Request a Claude code review using the vNext workflow t:llm Change Type - LLM related change (e.g. CLAUDE.md files)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants