llm: Add test constants placement rule to testing skill#6726
llm: Add test constants placement rule to testing skill#6726SaintPatrck merged 1 commit intomainfrom
Conversation
Document the convention of placing test constants as top-level private const val at the bottom of the file rather than in companion objects.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6726 +/- ##
=======================================
Coverage 86.16% 86.16%
=======================================
Files 840 840
Lines 59258 59258
Branches 8516 8516
=======================================
Hits 51060 51060
Misses 5244 5244
Partials 2954 2954
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Bitwarden Claude Code ReviewOverall Assessment: APPROVE Documentation-only change adding a "Test Constants Placement" section to the Code Review DetailsNo findings. Clean documentation addition with no code, security, or architectural concerns. |
🎟️ Tracking
LLM tooling improvement — no Jira ticket.
📔 Objective
Add a "Test Constants Placement" section to the
testing-android-codeskill documenting the convention: declare test constants as top-levelprivate const valat the bottom of the file, not insidecompanion object.