Skip to content

WIP Fix: adds support for eth/tokens unitDecimals > 18#425

Closed
cmgustavo wants to merge 3 commits into
bitpay:masterfrom
cmgustavo:bug/big-number-02
Closed

WIP Fix: adds support for eth/tokens unitDecimals > 18#425
cmgustavo wants to merge 3 commits into
bitpay:masterfrom
cmgustavo:bug/big-number-02

Conversation

@cmgustavo

@cmgustavo cmgustavo commented Sep 28, 2022

Copy link
Copy Markdown
Member

This PR shouldn't affect sending btc/bch/ltc, etc.

Required for sending ETH/Tokens: bitpay/bitcore#3441

@cmgustavo cmgustavo changed the title Fix: adds BN support for eth/tokens unitDecimals > 18 Fix: adds support for eth/tokens unitDecimals > 18 Sep 28, 2022
@cmgustavo cmgustavo force-pushed the bug/big-number-02 branch 2 times, most recently from 8d45ad1 to 75d6419 Compare October 13, 2022 15:07
@cmgustavo cmgustavo changed the title Fix: adds support for eth/tokens unitDecimals > 18 WIP Fix: adds support for eth/tokens unitDecimals > 18 Oct 13, 2022
@cmgustavo

Copy link
Copy Markdown
Member Author

Closed in favor of #451

@cmgustavo cmgustavo closed this Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant