Fix: Check ABI filters before build for old Android devices#2196
Open
cmgustavo wants to merge 1 commit into
Open
Fix: Check ABI filters before build for old Android devices#2196cmgustavo wants to merge 1 commit into
cmgustavo wants to merge 1 commit into
Conversation
Collaborator
|
Synced to Jira: https://bitpayprod.atlassian.net/browse/RN-2827 |
51c4831 to
ef4224a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The SIGABRT crash caused by missing
armeabi-v7aABI filters has happened twice (14.39.15 and 14.43.2). Both times the root cause was the same:armeabi-v7amissing fromandroid/app/build.gradle, affecting mid/low-end Android devices running in 32-bit mode.Solution
Add a
postinstallscript that validatesarmeabi-v7ais present in all 3 required locations inandroid/app/build.gradle:reactNativeArchitectures()default return valuendk { abiFilters }blockversionCodesmap