Skip to content

Bump MSRV to 1.63.0#1183

Merged
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:ci/bump_msrv_1630
Dec 12, 2023
Merged

Bump MSRV to 1.63.0#1183
notmandatory merged 1 commit intobitcoindevkit:masterfrom
notmandatory:ci/bump_msrv_1630

Conversation

@notmandatory
Copy link
Member

@notmandatory notmandatory commented Oct 25, 2023 •
edited
Loading

Description

fixes #331

Notes to the reviewers

We won't merge this PR until LDK merges lightningdevkit/rust-lightning#2681.

There are alot of clippy checks to fix at 1.63.0 so I left the clippy MSRV at 1.57.0 for now.

Changelog notice

Changed

  • MSRV is now 1.63.0 for bdk, chain, and bitcoind_rpc crates

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@notmandatory notmandatory self-assigned this Oct 25, 2023
realeinherjar
realeinherjar reviewed Oct 27, 2023
View reviewed changes
@realeinherjar realeinherjar mentioned this pull request Oct 28, 2023
Merged
6 tasks
@notmandatory notmandatory mentioned this pull request Oct 30, 2023
Merged
3 tasks
@evanlinjin
Copy link
Member

evanlinjin commented Oct 30, 2023

My intuition tells me this will make life a lot easier.

@notmandatory notmandatory mentioned this pull request Nov 4, 2023
Merged
@nondiremanuel nondiremanuel added this to the 1.0.0-alpha.3 milestone Nov 5, 2023
@nondiremanuel nondiremanuel mentioned this pull request Nov 5, 2023
Closed
38 tasks
@notmandatory notmandatory mentioned this pull request Nov 13, 2023
Closed
@notmandatory notmandatory modified the milestones: 1.0.0-alpha.3, 1.0.0-alpha.4 Nov 13, 2023
@nondiremanuel nondiremanuel mentioned this pull request Nov 19, 2023
Closed
54 tasks
@nondiremanuel nondiremanuel mentioned this pull request Dec 2, 2023
Closed
55 tasks
This was referenced Dec 8, 2023
Closed
Merged
@notmandatory
Copy link
Member Author

notmandatory commented Dec 8, 2023

Rebased on master branch.

@notmandatory
Copy link
Member Author

notmandatory commented Dec 8, 2023 •
edited
Loading

Now that lightningdevkit/rust-lightning#2681 was ACKed and will likely be merged soon I think we should get this one merged so we run into less broken CI builds.

@notmandatory notmandatory modified the milestones: 1.0.0-alpha.4, 1.0.0-alpha.3 Dec 8, 2023
evanlinjin
evanlinjin approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@evanlinjin evanlinjin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 169385b

@notmandatory notmandatory merged commit 908b0f9 into bitcoindevkit:master Dec 12, 2023
This was referenced Dec 12, 2023
Merged
Merged
Merged
@notmandatory notmandatory mentioned this pull request Dec 12, 2023
Merged
4 tasks
@nondiremanuel nondiremanuel mentioned this pull request Jan 1, 2024
Closed
24 tasks
@notmandatory notmandatory mentioned this pull request Jan 3, 2024
Closed
12 tasks
@notmandatory notmandatory deleted the ci/bump_msrv_1630 branch May 26, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@evanlinjin evanlinjin evanlinjin approved these changes

+1 more reviewer

@realeinherjar realeinherjar realeinherjar left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@notmandatory notmandatory

Labels

None yet

Projects

BDK Wallet
Archived in project

Milestone

1.0.0-alpha.3

Development

Successfully merging this pull request may close these issues.

Support for MSRV shipped with Debian stable for default features

4 participants

@notmandatory @evanlinjin @realeinherjar @nondiremanuel