Skip to content

Remove filterclear#443

Closed
rebroad wants to merge 1 commit intobitcoin:masterfrom
rebroad:Fix111
Closed

Remove filterclear#443
rebroad wants to merge 1 commit intobitcoin:masterfrom
rebroad:Fix111

Conversation

@rebroad
Copy link

@rebroad rebroad commented Sep 15, 2016

This message (filterclear) isn't included in the reasons for moving bloom services into a opt-out service.

Also, filterclear is a useful way for nodes to start with TX relay off and to request TX relay later. (e.g. during IBD).

Discussed in bitcoin/bitcoin#8709

This message isn't included in the reasosn for moving bloom services into a opt-out service.

Also, filterclear is a useful way for nodes to start with TX relay off and to request TX relay later. (e.g. during IBD).
@luke-jr
Copy link
Member

luke-jr commented Sep 16, 2016

@TheBlueMatt @petertodd

I think it's too late to change this, though...?

@TheBlueMatt
Copy link
Contributor

The context is bitcoin/bitcoin#8709
I support the idea, but the text needs to note that some versiond do ban for filterclear, but it is very strongly recommended (maybe MUST) that new versions do not do so.

@petertodd
Copy link
Contributor

Given the low consequences for connecting to a peer without this change - getting disconnected - I think it's reasonable to change this behavior and just phase it in over time. Also as @pstratem notes, reconnecting after IBD is sufficient for now: bitcoin/bitcoin#8709 (comment) (which retry logic in your implementation may very well do anyway!)

@luke-jr
Copy link
Member

luke-jr commented Jul 26, 2017

So is that an ack, or does it need changes? (What's the status here?)

@TheBlueMatt
Copy link
Contributor

This needs some text to note that some nodes on the network will additionally disconnect for filterclear, but new implementations MUST NOT do so.

@luke-jr
Copy link
Member

luke-jr commented Sep 16, 2017

@rebroad Please either finish or close this...

@rebroad
Copy link
Author

rebroad commented May 3, 2021

@TheBlueMatt @petertodd

I think it's too late to change this, though...?

i think it is now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants