Remove unused "What's This" button in dialogs on Windows OS#85
Merged
jonasschnelli merged 2 commits intobitcoin-core:masterfrom Jan 28, 2021
Merged
Remove unused "What's This" button in dialogs on Windows OS#85jonasschnelli merged 2 commits intobitcoin-core:masterfrom
jonasschnelli merged 2 commits intobitcoin-core:masterfrom
Conversation
Contributor
|
Please split this into two commits, otherwise literally every commit could be a scripted diff by including the diff as a patch in the commit body |
-BEGIN VERIFY SCRIPT- git grep -l 'QDialog(parent)' -- src/qt | xargs sed -i -E 's/QDialog\(parent\)/QDialog\(parent, GUIUtil::dialog_flags\)/g' -END VERIFY SCRIPT-
e322fe7 to
ac7ccd6
Compare
Member
Author
|
tACK ac7ccd6 Tested on Windows 10.0.18363 Build 18363. Master (
This PR also removes this unused dialog button from the following windows on Windows 10 compared to master.
|
Member
|
Is there a way we can exclude the "What's This?" button rather than explicitly list included buttons? |
Member
Author
Qt docs do not provide that way. |
promag
reviewed
Nov 18, 2020
|
|
||
| SendCoinsDialog::SendCoinsDialog(const PlatformStyle *_platformStyle, QWidget *parent) : | ||
| QDialog(parent), | ||
| QDialog(parent, GUIUtil::dialog_flags), |
Contributor
There was a problem hiding this comment.
It extends dialog but it's not used as such. I think you could drop this change?
Member
Author
There was a problem hiding this comment.
I think you could drop this change?
Adding widget flags to remove "What's This" button is the goal of this PR. Or did I understand you in a wrong way?
|
|
||
| ReceiveCoinsDialog::ReceiveCoinsDialog(const PlatformStyle *_platformStyle, QWidget *parent) : | ||
| QDialog(parent), | ||
| QDialog(parent, GUIUtil::dialog_flags), |
sidhujag
pushed a commit
to syscoin/syscoin
that referenced
this pull request
Jan 28, 2021
…ogs on Windows OS ac7ccd6 scripted-diff: Remove unused "What's This" button in dialogs on Windows (Hennadii Stepanov) b695148 qt: Add flags to prevent a "What's This" button on Windows OS (Hennadii Stepanov) Pull request description: Fix #74. From [Qt docs](https://doc.qt.io/qt-5/qdialog.html#QDialog): > The widget flags _f_ are passed on to the `QWidget` constructor. If, for example, you don't want a **What's This** button in the title bar of the dialog, pass `Qt::WindowTitleHint | Qt::WindowSystemMenuHint` in _f_. Screenshot on Windows 10 (2004): - master (3ba25e3)  - this PR (e322fe7)  ACKs for top commit: Bosch-0: tACK ac7ccd6 Tested on Windows 10.0.18363 Build 18363. promag: Code review ACK ac7ccd6 but with some suggestions. jonasschnelli: utACK ac7ccd6 Tree-SHA512: f6750a17b7203106cb4db5870becba1cef6a505d4edcc710ba131338bd3aae051510627e62c9bcb8345a7f497c614709e11aeb8f6ae3ea85967bbce2a8c69e64
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #74.
From Qt docs:
Screenshot on Windows 10 (2004):
master (3ba25e3)
this PR (e322fe7)
