Skip to content

Update translation source file for v27.0 string freeze#793

Merged
hebasto merged 1 commit into
bitcoin-core:masterfrom
hebasto:240213-tr
Feb 13, 2024
Merged

Update translation source file for v27.0 string freeze#793
hebasto merged 1 commit into
bitcoin-core:masterfrom
hebasto:240213-tr

Conversation

@hebasto

@hebasto hebasto commented Feb 13, 2024

Copy link
Copy Markdown
Member

This PR updates the src/qt/locale/bitcoin_en.xlf translation source file according to the Release schedule for 27.0.

Note for reviewers: it is expected to get a zero diff after running make -C src translate locally.

The diff is produced by running `make -C src translate`.
@DrahtBot

DrahtBot commented Feb 13, 2024

Copy link
Copy Markdown
Contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK jarolrod

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

@hebasto hebasto changed the title qt: Update translation source file for v27.0 string freeze Update translation source file for v27.0 string freeze Feb 13, 2024
@hebasto

hebasto commented Feb 13, 2024

Copy link
Copy Markdown
Member Author

Friendly ping @jarolrod @johnny9 @pablomartin4btc :)

@jarolrod jarolrod left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 3d1bb1a

Have zero-diff with this pr

@hebasto
hebasto merged commit baed5ed into bitcoin-core:master Feb 13, 2024
@hernanmarino

Copy link
Copy Markdown
Contributor

I'm a little late but, in order to collaborate with this in the future what exactly should I be diffing ? between what branches/ files ? Thanks

@pablomartin4btc

Copy link
Copy Markdown
Contributor

@hernanmarino check this guide (there's an ongoing small correction) and see this PR was done on the core repo recently as an example.

@hernanmarino

Copy link
Copy Markdown
Contributor

@hernanmarino check this guide (there's an ongoing small correction) and see this PR was done on the core repo recently as an example.

I read the guide (and your PR) and it doesn´t mention what branches/commits/files to diff

I performed a diff on th PR branch after the make instructions and master and found several differences but I am obviously doing something wrong ...

@pablomartin4btc

Copy link
Copy Markdown
Contributor

I think you don't need to run the python script cos that core PR I mentioned above was already merged on this gui repo before this PR and since this PR is now merged too, you would need to perform just the make command on master before this PR.

@hebasto

hebasto commented Feb 14, 2024

Copy link
Copy Markdown
Member Author

@hernanmarino

I'm a little late but, in order to collaborate with this in the future what exactly should I be diffing ? between what branches/ files ? Thanks

Thank you for your interest!

Here are all steps to verify this PR (and similar ones in the future):

git fetch origin pull/793/head
git checkout FETCH_HEAD
make -C depends -j $(nproc) MULTIPROCESS=1
./autogen.sh
./configure CONFIG_SITE=$PWD/depends/x86_64-pc-linux-gnu/share/config.site  # Use the corresponding path if building on macOS
make -C src translate
git diff  # must have an empty output

@pablomartin4btc pablomartin4btc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-merge tACK 3d1bb1a

no diff

@hebasto
hebasto deleted the 240213-tr branch February 15, 2024 10:32
@hebasto hebasto added this to the 27.0 milestone Feb 15, 2024
@bitcoin-core bitcoin-core locked and limited conversation to collaborators Aug 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants