Faster look up for input selection in multi file tab#943
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves performance in the multi-file analysis tab by avoiding duration probing for every audio file when only a preview (and a total count) is needed.
Changes:
- Added a fast audio-file counting helper in core utilities (
utils.count_audio_files) that walks the directory without storing/sorting paths. - Exposed the counting helper through GUI utilities (
gui.utils.count_audio_files). - Updated the multi-file tab input selection to load durations only for a limited preview set and to compute the “more files” label using the fast counter.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
birdnet_analyzer/utils.py |
Adds count_audio_files() to efficiently count eligible audio files via os.walk. |
birdnet_analyzer/gui/utils.py |
Adds a GUI-level wrapper to access the core count_audio_files() utility. |
birdnet_analyzer/gui/multi_file.py |
Limits duration probing to a preview set and uses the fast counter to show how many additional files exist. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+152
to
+154
| # Only load durations for the first files shown in the preview. | ||
| # Fetch one extra to detect whether more files exist without | ||
| # walking (and probing durations for) the whole directory. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.