Implement lazy initialization for UnimodDatabase#63
Merged
Conversation
Contributor
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
PR Code Suggestions ✨No code suggestions found for the PR. |
Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
ypriverol
approved these changes
Nov 27, 2025
Co-authored-by: ypriverol <52113+ypriverol@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix feedback on PTM diann handling updates
Implement lazy initialization for UnimodDatabase
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback that
unimod_databaseinitialized at module import time hurts testability and prevents database refresh scenarios.Changes
unimod_database = UnimodDatabase()with aget_unimod_database()getter that creates the instance on first access_unimod_databasemodule variable, enabling tests to reset by setting toNoneget_mod()now usesget_unimod_database().modificationsBenefits: faster module imports, easier mocking in tests, database only created when needed.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.