local data backend double-traversal fix - #2836
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors the
list_filesmethod inLocalDataBackendto improve file discovery, especially with symlinks and forbidden directories, and adds comprehensive unit tests to ensure correct behavior. The new implementation usesos.walkto traverse directories, prevents duplicate file listings due to symlink cycles, and excludes files in forbidden directories.Refactor and bug fixes in file listing:
list_filesto useos.walkwith symlink support, preventing duplicate files from symlink cycles and ensuring forbidden directories are pruned from traversal. [1] [2]Testing improvements:
TestLocalDataBackendListFilesintest_local_files.pyto verify that:.ipynb_checkpoints) are properly excluded from results.