(#2606) pixart two-stage pipeline inference support (v0.7 MoE variant) - #2822
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds multistage (two-stage) validation support for PixArt v0.7 split pipelines, allowing validation to run either only the trained stage or the full stage1→stage2 chain. It also wires the new options into config/UI integration and introduces unit tests covering the new PixArt validation behavior.
Changes:
- Added PixArt multistage validation plumbing in
PixartSigma(mode selection, stage pipeline selection, and chained validation execution). - Registered new PixArt validation config fields for CLI/UI discovery and env var mapping.
- Added PixArt multistage validation unit tests and documented the new CLI options.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
simpletuner/helpers/models/pixart/model.py |
Implements PixArt multistage validation mode parsing and the stage1→stage2 validation call chain. |
simpletuner/helpers/models/field_registry/pixart.py |
Registers the PixArt validation options with the field registry for UI/config integration. |
simpletuner/helpers/configuration/env_file.py |
Adds env var → CLI arg mappings for the new PixArt validation options. |
tests/test_pixart_multistage_validation.py |
Introduces unit tests that exercise the PixArt multistage validation code paths. |
tests/test_model_field_registry.py |
Ensures the PixArt field registry module is discovered by the registry tests. |
documentation/OPTIONS.md |
Documents the new PixArt validation CLI options. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2606
This pull request adds support for multistage validation to the PixArt model, allowing validation to run in either "trained stage only" or "full pipeline" modes. It introduces new configuration options, updates the model registry and configuration helpers, and provides comprehensive tests for the new validation logic.
PixArt multistage validation support:
--pixart_validation_pipeline_mode,--pixart_validation_stage1_model,--pixart_validation_stage2_model) to select validation mode and specify fixed models for each stage. [1] [2]PixartSigma, including methods for determining the validation mode, selecting the appropriate pipeline for each stage, handling schedule boundaries, and running chained validation across stages. [1] [2]Testing and documentation:
tests/test_pixart_multistage_validation.pyto cover all major code paths and edge cases for PixArt multistage validation.Other improvements:
pixart/model.py.