(#2607) Wan MoE validation improvements - #2817
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds support for paired-stage validation for Wan 2.2 and compatible staged flavours (such as AnimeGen), allowing validation to use both stages and switch denoisers at the configured boundary. It introduces a new configuration option, updates the model and SDK to support this feature, and adds comprehensive tests and documentation in multiple languages.
Support for paired-stage validation in Wan 2.2:
--wan_validation_load_other_stageto enable loading the opposite stage during validation, with documentation in English, Spanish, Hindi, Japanese, Portuguese, and Chinese (OPTIONS.md,OPTIONS.es.md,OPTIONS.hi.md,OPTIONS.ja.md,OPTIONS.pt-BR.md,OPTIONS.zh.md). [1] [2] [3] [4] [5] [6]simpletuner/simpletuner_sdk/server/services/field_registry/sections/validation.py).Model and pipeline enhancements:
Wanmodel class to support multi-stage validation, with logic to load the peer stage and switch denoisers, and added theSUPPORTS_MULTISTAGE_VALIDATIONflag and related methods (simpletuner/helpers/models/wan/model.py). [1] [2] [3]simpletuner/helpers/configuration/env_file.py).Testing and validation:
Wanmodel, covering pipeline setup, configuration, and cache management (tests/test_wan_model.py). [1] [2] [3]tests/test_models_service_validation_preview.py).