Skip to content

deepfloyd: refactor pipeline handling (#2604) - #2816

Merged
bghira merged 2 commits into
mainfrom
feature/deepfloyd-validation-refactor
Jul 16, 2026
Merged

deepfloyd: refactor pipeline handling (#2604)#2816
bghira merged 2 commits into
mainfrom
feature/deepfloyd-validation-refactor

Conversation

@bghira

@bghira bghira commented Jul 15, 2026

Copy link
Copy Markdown
Owner

This pull request introduces comprehensive support for DeepFloyd multi-stage validation across the codebase and documentation. It adds new configuration options, updates environment variable mappings, and enhances model interface hooks to allow for flexible and explicit control of DeepFloyd validation stages, including custom model selection and upscaling. Documentation in multiple languages has been updated to reflect these new options.

DeepFloyd Validation Pipeline Support

  • Added new configuration options for DeepFloyd validation: pipeline mode, fixed models for each stage, upscaler options, inference steps, guidance, and noise level, with detailed explanations in documentation (OPTIONS.md, .es.md, .hi.md, .ja.md, .pt-BR.md, .zh.md). [1] [2] [3] [4] [5] [6]
  • Updated env_file.py to map new DeepFloyd validation environment variables to their corresponding CLI arguments.
  • In model.py, added default model constants, upscaler default, and valid mode sets for DeepFloyd validation.
  • Enhanced common.py with an optional unload_validation_models hook for releasing validation-only components, and clarified/adjusted the multi-stage validation interface to support new pipeline call signatures. [1] [2] [3]
  • Updated DeepFloyd model dependencies to include the SD x4 upscaler pipeline.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds first-class DeepFloyd multi-stage validation support, exposing new CLI/WebUI configuration fields, wiring env-var mappings, extending the model interface for multi-stage pipeline execution (including optional upscaling), and updating docs/translations accordingly.

Changes:

  • Add DeepFloyd validation configuration options (pipeline mode, per-stage fixed models, stage III upscaler mode/model, per-stage guidance/steps, noise level) and register them in the WebUI field registry.
  • Implement DeepFloyd-owned multi-stage validation execution (stage I → stage II, optional SD x4 upscaler as “stage III”) plus a validation-model unload hook for releasing validation-only components.
  • Add/adjust tests to assert DeepFloyd multistage capability and validate stage-chaining behavior.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/test_models_service_validation_preview.py Updates model capability expectation so DeepFloyd is treated as multistage-capable.
tests/test_deepfloyd_multistage_validation.py New unit tests covering DeepFloyd multistage mode selection and stage chaining (including stage III prompt passthrough).
simpletuner/simpletuner_sdk/server/services/field_registry/sections/validation.py Adds DeepFloyd validation fields to the WebUI registry (mode/models/steps/guidance/noise).
simpletuner/helpers/training/validation.py Routes validation inputs/behavior based on multistage support and adds multistage pipeline-call plumbing + prompt text passthrough for stage III.
simpletuner/helpers/models/deepfloyd/model.py Implements DeepFloyd multistage validation, validation pipeline loading/caching, and stage III upscaler support.
simpletuner/helpers/models/common.py Extends the multistage validation interface and adds a no-op unload_validation_models() hook.
simpletuner/helpers/configuration/env_file.py Maps new DeepFloyd validation env vars to CLI arguments.
documentation/OPTIONS.md Documents the new DeepFloyd validation options (English).
documentation/OPTIONS.es.md Spanish translation of the new DeepFloyd validation option docs.
documentation/OPTIONS.hi.md Hindi translation of the new DeepFloyd validation option docs.
documentation/OPTIONS.ja.md Japanese translation of the new DeepFloyd validation option docs.
documentation/OPTIONS.pt-BR.md Brazilian Portuguese translation of the new DeepFloyd validation option docs.
documentation/OPTIONS.zh.md Chinese translation of the new DeepFloyd validation option docs.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread simpletuner/helpers/training/validation.py
Comment thread simpletuner/helpers/models/deepfloyd/model.py
@bghira
bghira merged commit 55e0d9c into main Jul 16, 2026
3 checks passed
@bghira
bghira deleted the feature/deepfloyd-validation-refactor branch July 16, 2026 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants