Skip to content

Conversation

@matthewnessworthy
Copy link
Contributor

No description provided.

@matthewnessworthy
Copy link
Contributor Author

@mpociot please can you take a look when you have a moment

@matthewnessworthy
Copy link
Contributor Author

@mpociot 👋

@intellow
Copy link

intellow commented Mar 9, 2020

@matthewnessworthy You need to update orchestra/testbench to include up to version 5.0. This ensures the test suite is run with Laravel 7.

@matthewnessworthy
Copy link
Contributor Author

@intellow all the tests pass, why would additional changes be needed?

@intellow
Copy link

intellow commented Mar 9, 2020

@intellow all the tests pass, why would additional changes be needed?

The version of orchestra/testbench defines what version of Laravel is used when the tests are run. Right now, with the version set to 3.6.*, the test suite is running (and passing) on a Laravel 5.6 app. We need to make sure the tests still pass when running on a Laravel 7 app.

@matthewnessworthy
Copy link
Contributor Author

@intellow
i've made some updates to test various versions of laravel against various versions of php
all seems to be working fine, but Scrutinizer appears to be failing with no error message

@mpociot mpociot merged commit 5e94a18 into beyondcode:master Mar 11, 2020
@mpociot
Copy link
Member

mpociot commented Mar 11, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants