Skip to content

feat(android-llmservice): add shard-J launcher icon#349

Merged
bernardladenthin merged 1 commit into
mainfrom
claude/llama-cpp-subproject-logos-rtc8ge
Jul 17, 2026
Merged

feat(android-llmservice): add shard-J launcher icon#349
bernardladenthin merged 1 commit into
mainfrom
claude/llama-cpp-subproject-logos-rtc8ge

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Wires the shard-J launcher icon (from the shared workspace logo set) into the LLM Service Android app, which previously shipped with no icon (default Android launcher glyph).

This is the launcher-icon commit that did not land when #348 was merged (only the README-logo commit made it into that merge); the branch has been rebased onto the current main, so this PR now contains only the launcher-icon change.

Changes

  • Adds the adaptive-icon set under android-llmservice/app/src/main/res/:
    • mipmap-{m,h,x,xx,xxx}dpi/ic_launcher.png + ic_launcher_foreground.png
    • mipmap-anydpi-v26/ic_launcher.xml (adaptive foreground + @color/ic_launcher_background)
    • values/ic_launcher_background.xml (#111111)
  • Sets android:icon / android:roundIcon = @mipmap/ic_launcher in AndroidManifest.xml.
  • Documents it as requirement R1.7 in android-llmservice/requirements.md.
  • REUSE: the launcher PNGs are annotated MIT OR Apache-2.0 in REUSE.toml; the two XMLs carry inline SPDX headers. reuse lint is green.

Verification

  • reuse lint → compliant (431/431 files).
  • The adaptive references (@mipmap/ic_launcher_foreground, @color/ic_launcher_background) resolve. A full Gradle/AGP build was not run locally (no Android SDK in the sandbox) — the build-android-llmservice CI job is the build gate.

🤖 Generated with Claude Code

https://claude.ai/code/session_01EqBKwPNJSfaSnTVgw87CPT


Generated by Claude Code

Wire the new adaptive launcher-icon set (from the shared workspace logo:
the shard-J on #111111) into the LLM Service app. Adds the mipmap-* PNGs,
the adaptive-icon descriptor + ic_launcher_background colour, and sets
android:icon/android:roundIcon in the manifest (the app previously shipped
no icon). Documents it as requirement R1.7 and REUSE-annotates the PNGs as
MIT OR Apache-2.0 (the XMLs carry inline SPDX).

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EqBKwPNJSfaSnTVgw87CPT
@bernardladenthin
bernardladenthin merged commit 8ed6c7d into main Jul 17, 2026
9 of 14 checks passed
@bernardladenthin
bernardladenthin deleted the claude/llama-cpp-subproject-logos-rtc8ge branch July 17, 2026 19:15
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants