fix: benchmark names with multiple lines #620
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the fix for the problem on discord https://discord.com/channels/1074890101362004088/1412794833072033903/1413138826645209198 and as discussed in #619. Because there's no github issue: Here's a quick summary of the problem and the solution:
In the output of the slang benchmark there are benchmarks which have a multiline benchmark name. These benchmarks are not parsed correctly and are skipped by the current parser which causes the discrepancy between the expected amount of
12benchmarks and the actual amount of7in this benchmark run https://github.com/NomicFoundation/slang/actions/runs/17408413743/job/49418989630. This issue arises in gungraun due to the use of syn'sto_stringfunction, which occasionally splits strings across multiple lines. While this behavior may not be considered a bug within gungraun, it deviates from the original intention of keeping both the benchmark name and description on a single line.This pr contains a fix for the parser to accept benchmark names on multiple lines. Multiline benchmark names and descriptions will be removed in future versions of gungraun but this fix should work for all versions of gungraun/iai-callgrind.