Skip to content

Akoutmos adding table support - #377

Merged
PragTob merged 11 commits into
mainfrom
akoutmos-adding-table-support
Dec 23, 2022
Merged

Akoutmos adding table support#377
PragTob merged 11 commits into
mainfrom
akoutmos-adding-table-support

Conversation

@PragTob

@PragTob PragTob commented Dec 22, 2022

Copy link
Copy Markdown
Member

Follow up to #369

  • Some naming/code changes
  • Only render out data from measurements that have actually been taken, seems like a good idea
    • add some functions to support operating over all the data/just the used data more smoothly
  • change order slightly so we preserve run time, memory, reductions

@PragTob

PragTob commented Dec 22, 2022

Copy link
Copy Markdown
Member Author

So, with benchee's very optimistic support goals dating back to elixir 1.6 we're clashing with table that used __STACKTRACE__ introduced in 1.7.

So options are:

  • spin out as a separate package after all
  • fiddle with CI to not attempt to install table on unsupported versions

@PragTob
PragTob force-pushed the akoutmos-adding-table-support branch from cc19a38 to 556de81 Compare December 23, 2022 10:33
@PragTob
PragTob merged commit b839502 into main Dec 23, 2022
@PragTob
PragTob deleted the akoutmos-adding-table-support branch December 23, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants