Skip to content

Display unresolved comments at the bottom #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benbernard merged 1 commit into from
Oct 9, 2017
Merged

Display unresolved comments at the bottom #4

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tracker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@
// Other file forwarders
var Parse;
var waitForKeyElements;
var unresolvedComments = new Set();

var findAllThreads = function () {
var threads = [];
Expand Down Expand Up @@ -143,10 +144,12 @@ var updateMergeButton = function () {
' <span class="status-meta">' +
' See above for red unresolved comments' +
' </span>' +
' <lu><li>' + Array.from(unresolvedComments).join('</li><li>') + "</li></lu>" +
' </div>'
);
}
}
unresolvedComments.clear();
};

var annotateWithParseInfo = function (allThreads) {
Expand Down Expand Up @@ -211,6 +214,11 @@ var makeButton = function (elem, threadInfo) {

updateThread(threadInfo);
});

var content = $elem.find(actionSelector)[0].innerText.trim();
if (content != "") {
unresolvedComments.add(content);
}
}
};

Expand Down