Move Babel packages from dependencies to devDependencies#60
Open
h-takeyeah wants to merge 1 commit into
Open
Conversation
Author
|
BTW, I used Node.js v18.20.8 based on repository's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move Babel packages listed below from dependencies to devDependencies.
Description
The babel packages are build/transpile tools that consumers of
@bbc/tv-lrud-spatialdon't need at runtime.Moving them from dependencies to devDependencies reduces disk usage of the consumers and might mitigate potential build tool's version conflict issues.
Motivation and Context
fix #59
How Has This Been Tested?
npm packon the forked repo.@bbc/tv-lrud-spatialfrom a file.summary:
full result: babel-will-not-installed.txt
npm test failed
npm testagainst the commit was failed on my machine.Test was executed on my machine: Ubuntu 26.04 LTS / Wayland / Chrome linux-144.0.7559.96 / puppeteer@24.36.1
full log: npm-test-against-b07b553fec0564a9e3336767397bc83ef9f3e8e5.txt
At least the current master branch code(13ff5d9) passes CI, and since this PR doesn't touch that code, I think the issue should be fine 👍 and Firefox does not reproduce the issue 🫤. I confirmed that by launching debug server with
npm run serverand visiting the page (http://localhost:3005/test/layouts/0c-3f-distance.html).Checklist: