fix: handle object and multi-object custom fields correctly#452
Merged
bb-Ricardo merged 1 commit intobb-Ricardo:developmentfrom Jul 23, 2025
Merged
fix: handle object and multi-object custom fields correctly#452bb-Ricardo merged 1 commit intobb-Ricardo:developmentfrom
bb-Ricardo merged 1 commit intobb-Ricardo:developmentfrom
Conversation
Owner
|
Thank you so much for the fix. Will have a look at it. |
Author
|
Hi @bb-Ricardo , can you update on this? Theres a bunch of devices and VMs which arent "updating" or stopped updating because of this. For example, having a custom field with a linked object type will always fail after netbox-sync tries an PATCH. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Custom Fields with object/multi-object type handling #451
Problem
When patching NetBox objects with custom fields of type "object" or "multi-object", netbox-sync tries to use the complete object representation received from the API instead of just the required object IDs. This causes errors like:
The API returns object references in custom fields with properties like
id,url,display, andname, but when patching, NetBox only expects the ID(s) of the referenced object(s).Solution
Modified the update method in the NetBoxObject class to properly handle custom fields of type "object" and "multi-object". When patching values:
Implementation Details
{"id": 123, "display": "Object", ...}to just123