Skip to content

[email protected] #6714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
aspect-marvin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[email protected] #6714

aspect-marvin wants to merge 1 commit into from
+156 −1

Conversation

@aspect-marvin
Copy link
Contributor

@aspect-marvin aspect-marvin commented Dec 3, 2025

@bazel-io
Copy link
Member

bazel-io commented Dec 3, 2025

Hello @alexeagle, modules you maintain (aspect_rules_lint) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Dec 3, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds version 1.12.0 of the aspect_rules_lint module to the Bazel Central Registry. The overall structure of the submission is correct and follows the BCR guidelines. However, I've found a critical issue in the MODULE.bazel file that will cause build failures for downstream users. The multitool.hub calls use workspace-root-relative paths for lockfiles, which will not resolve correctly when the module is used as a dependency. Please see the detailed comment for the required fix.

@meteorcloudy meteorcloudy force-pushed the aspect_rules_lint-v1.12.0 branch from 9ac9759 to cf02116 Compare December 3, 2025 15:24
@meteorcloudy meteorcloudy added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@aspect-marvin @bazel-io @meteorcloudy @alexeagle