-
Notifications
You must be signed in to change notification settings - Fork 614
Fix boost spirit and add mqtt5 #6653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Fix boost spirit and add mqtt5 #6653
Conversation
|
Hello @wep21, @Vertexwahn, modules you maintain (boost.spirit) have been updated in this PR. |
|
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.mqtt5) have been updated in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces the boost.mqtt5 module and provides a fix for boost.spirit by adding a new version. While the structure and intent are mostly correct, there are a couple of critical copy-paste errors in the MODULE.bazel files within the overlays. Specifically, boost.mqtt5's MODULE.bazel is incorrectly copied from boost.math, and boost.spirit's MODULE.bazel has an outdated version string. These issues must be fixed for the modules to be correctly resolved by Bazel.
8910deb to
2da1781
Compare
|
@bazel-io skip_check unstable_url |
|
@martin4861 Please update integrity with |
@wep21 Done! How are boost versions usually released? I only created mqtt5 and spirit for 1.89.0.bcr.2, but for other versions all boost modules have been created. |
6d7080b to
905cfab
Compare
|
@fmeum @meteorcloudy please add presubmit auto run tag. |
|
@bazel-io skip_check incompatible_flags |
That other PR should hopefully get merged in the next day or two, so if you can wait that would probably be the easiest. It is expected now (as of recently) that a new bcr version for all the other boost submodules should be generated whenever one is updated. That is done by running There is an ongoing discussion happening about that PR and its implications here: #6511 |
include/boost/spirit/home/x3/nonterminal/detail/rule.hpptoboost.spiritboost.mqtt5