Skip to content

Conversation

@martin4861
Copy link
Contributor

@martin4861 martin4861 commented Nov 28, 2025

  • Add textual header include/boost/spirit/home/x3/nonterminal/detail/rule.hpp to boost.spirit
  • Add boost.mqtt5

@bazel-io
Copy link
Member

Hello @wep21, @Vertexwahn, modules you maintain (boost.spirit) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (boost.mqtt5) have been updated in this PR.
Please review the changes. You can view a diff against the previous version in the "Generate module diff" check.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the boost.mqtt5 module and provides a fix for boost.spirit by adding a new version. While the structure and intent are mostly correct, there are a couple of critical copy-paste errors in the MODULE.bazel files within the overlays. Specifically, boost.mqtt5's MODULE.bazel is incorrectly copied from boost.math, and boost.spirit's MODULE.bazel has an outdated version string. These issues must be fixed for the modules to be correctly resolved by Bazel.

@martin4861 martin4861 force-pushed the fix-boost-spirit-and-add-mqtt5 branch 2 times, most recently from 8910deb to 2da1781 Compare November 28, 2025 15:29
@wep21
Copy link
Contributor

wep21 commented Nov 29, 2025

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Nov 29, 2025
@martin4861 martin4861 requested a review from wep21 December 1, 2025 08:57
@wep21
Copy link
Contributor

wep21 commented Dec 1, 2025

@martin4861 Please update integrity with

bazelisk run //tools:update_integrity -- boost.spirit --version 1.89.0.bcr.2

@martin4861
Copy link
Contributor Author

martin4861 commented Dec 2, 2025

@martin4861 Please update integrity with

bazelisk run //tools:update_integrity -- boost.spirit --version 1.89.0.bcr.2

@wep21 Done! How are boost versions usually released? I only created mqtt5 and spirit for 1.89.0.bcr.2, but for other versions all boost modules have been created.

@martin4861 martin4861 force-pushed the fix-boost-spirit-and-add-mqtt5 branch from 6d7080b to 905cfab Compare December 3, 2025 15:28
@wep21
Copy link
Contributor

wep21 commented Dec 3, 2025

@fmeum @meteorcloudy please add presubmit auto run tag.

@wep21
Copy link
Contributor

wep21 commented Dec 3, 2025

I'm not sure about the current status of this PR.
#6530

@fmeum @kgreenek Is it better to wait for the PR merged?

@fmeum fmeum added the presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval label Dec 3, 2025
@fmeum fmeum enabled auto-merge (squash) December 3, 2025 16:41
@martin4861
Copy link
Contributor Author

@bazel-io skip_check incompatible_flags

@bazel-io bazel-io added the skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit label Dec 3, 2025
@kgreenek
Copy link
Contributor

kgreenek commented Dec 11, 2025

I'm not sure about the current status of this PR. #6530

@fmeum @kgreenek Is it better to wait for the PR merged?

That other PR should hopefully get merged in the next day or two, so if you can wait that would probably be the easiest.

It is expected now (as of recently) that a new bcr version for all the other boost submodules should be generated whenever one is updated. That is done by running python3 modules/boost/add_boost_version.py <version>

There is an ongoing discussion happening about that PR and its implications here: #6511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

presubmit-auto-run Presubmit jobs will be triggered for new changes automatically without reviewer's approval skip-incompatible-flags-test Bypass the incompatible flags test in BCR presubmit skip-url-stability-check Skip the URL stability check for the PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants