Merged
Conversation
Owner
|
Thanks for the new fixes! Do you know if these changes are compatible with IDA 6.95? |
Contributor
Author
|
@bazad No, sadly. And I can't really test it. |
Open
Also add a retry limit when calling idc.RemoveFchunk in a loop.
Owner
|
@stek29 I've tested the pull request and have a small change to reintroduce support for 6.95. I'd appreciate if you could test it again on IDA7 before I merge. Could you grant me push access to the ida7 branch and check if everything still works? |
Contributor
Author
|
@bazad how would I? "Allow edits from maintainers" is checked. |
Owner
|
@stek29 Ah, sorry, I should have tried first. I've added the 6.95 fixes, let me know if it looks good. |
Contributor
Author
|
lgtm, would test in a couple of hours |
Contributor
Author
|
Sorry, forgot to respond -- it worked fine for me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.