Skip to content

Add Truffleruby head to CI - #120

Closed
gogainda wants to merge 2 commits into
basecamp:masterfrom
gogainda:patch-2
Closed

Add Truffleruby head to CI#120
gogainda wants to merge 2 commits into
basecamp:masterfrom
gogainda:patch-2

Conversation

@gogainda

@gogainda gogainda commented Feb 6, 2021

Copy link
Copy Markdown

No description provided.

@gogainda gogainda closed this Feb 11, 2021
@gogainda gogainda reopened this Mar 20, 2021
@gogainda

Copy link
Copy Markdown
Author

@byroot pls review/merge

@byroot

byroot commented Mar 23, 2021

Copy link
Copy Markdown
Collaborator

What's the goal here? Marginalia is a very simple gem, why does it need to be tested against truffle-head?

@gogainda

Copy link
Copy Markdown
Author

once tests are passing against truffleruby(like here) we are adding it to the list of supported gems here https://github.com/eregon/truffleruby-gem-tracker It will help us to track any regressions which may occur during development

@byroot

byroot commented Mar 23, 2021

Copy link
Copy Markdown
Collaborator

The thing is I can't think of anything in Marginalia that would break on Truffle, that wouldn't already break in dozens if not hundreds of other gems.

If it was a stable release then maybe, but running -head without marking it as allowing failure is a support burden.

Also this makes CI 7 times slower. I really don't see the usefulness really.

@sj26

sj26 commented Aug 8, 2021

Copy link
Copy Markdown
Collaborator

Thanks, but CI has been moved to GitHub Actions in #124.

@sj26 sj26 closed this Aug 8, 2021
@byroot byroot mentioned this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants