fix: prevent nil pointer panic in vsock proxy connection pool#106
Open
danilaverbena wants to merge 1 commit into
Open
fix: prevent nil pointer panic in vsock proxy connection pool#106danilaverbena wants to merge 1 commit into
danilaverbena wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The HTTP proxy in
cmd/server/main.gocan panic whenvsock.Dialfails insidesync.Pool.New. WhenNewreturnsnil, the single-value type assertionpool.Get().(*vsock.Conn)panics with *interface conversion: interface is nil, not vsock.Conn.Fix
Use the two-value form of the type assertion:
conn, ok := pool.Get().(*vsock.Conn). Also checkconn == nilin case a nil*vsock.Connwas previously returned to the pool.Impact
Without this fix, if the vsock service is unavailable, any HTTP request to the proxy server will cause a panic and crash the entire server process. With this fix, the proxy returns HTTP 500 instead.
Related
This was found during a security audit of op-enclave.