You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… sync
Log MissingCanonicalHeader errors at INFO level instead of ERROR when
node is starting up, restoring from snapshot, or still syncing. This
reduces log noise for expected conditions while preserving ERROR level
for actual issues.
Closesbase#398
I don't think this is useful. We need the error message to inform node operators what is going on - why their node is seemingly caught up to tip but unable to process Flashblocks. Hiding that information from them doesnt help
…iled context
Address reviewer feedback by:
- Change log level from INFO to WARN so operators can see the message
without triggering error alerts
- Add detailed context: required_block, flashblock_block, flashblock_index
- Add helpful hint explaining when processing will resume
- Add canonical_sync_wait metric for monitoring sync-related pauses
This ensures operators have full visibility into why Flashblock processing
is paused during node startup/sync, while avoiding unnecessary error noise.
I don't think this is useful. We need the error message to inform node operators what is going on - why their node is seemingly caught up to tip but unable to process Flashblocks. Hiding that information from them doesnt help
Understood 👍
Fair point. Updated to use WARN instead of INFO, added detailed context (required_block, flashblock info), and a new canonical_sync_wait metric. Operators get full visibility without error level noise. I hope its okey :)
I still don't feel like this provides value to be honest. The error message you're changing to is not one we want to have - the old error message containing the message about when it's okay to ignore is important to keep there. Bumping it down to a warn and introducing the metric are not things we really need to do. I'm going to close this out.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MissingCanonicalHeadererrors at INFO level instead of ERROR during node startup, snapshot restore, or syncCloses #398